From: Marcelo Ricardo Leitner <mleitner@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Huang Ying <ying.huang@intel.com>,
Alexei Starovoitov <ast@plumgrid.com>,
Jan Stancek <jstancek@redhat.com>,
Jesper Brouer <brouer@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: pktgen: don't abuse current->state in pktgen_thread_worker()
Date: Tue, 4 Aug 2015 13:40:56 -0300 [thread overview]
Message-ID: <20150804164056.GA2758@localhost.localdomain> (raw)
In-Reply-To: <20150804163334.GA31842@redhat.com>
On Tue, Aug 04, 2015 at 06:33:34PM +0200, Oleg Nesterov wrote:
> Commit 1fbe4b46caca "net: pktgen: kill the Wait for kthread_stop
> code in pktgen_thread_worker()" removed (in particular) the final
> __set_current_state(TASK_RUNNING) and I didn't notice the previous
> set_current_state(TASK_INTERRUPTIBLE). This triggers the warning
> in __might_sleep() after return.
>
> Afaics, we can simply remove both set_current_state()'s, and we
> could do this a long ago right after ef87979c273a2 "pktgen: better
> scheduler friendliness" which changed pktgen_thread_worker() to
> use wait_event_interruptible_timeout().
>
> Reported-by: Huang Ying <ying.huang@intel.com>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Interesting that it didn't happen in my tests yet per description it
should have. Huang, did you do anything special to trigger this?
next prev parent reply other threads:[~2015-08-04 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 16:33 [PATCH] net: pktgen: don't abuse current->state in pktgen_thread_worker() Oleg Nesterov
2015-08-04 16:40 ` Marcelo Ricardo Leitner [this message]
2015-08-04 17:08 ` Oleg Nesterov
2015-08-04 17:30 ` Marcelo Ricardo Leitner
2015-08-07 6:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804164056.GA2758@localhost.localdomain \
--to=mleitner@redhat.com \
--cc=ast@plumgrid.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=jstancek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.