From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH V3 request from stable 3.10 to 3.14] efi: fix 32bit kernel boot failed problem using efi Date: Tue, 4 Aug 2015 18:12:56 +0100 Message-ID: <20150804171256.GA4332@codeblueprint.co.uk> References: <1438653081-25746-1-git-send-email-fupan.li@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1438653081-25746-1-git-send-email-fupan.li-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: fupan.li-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, jslaby-AlSwsSmVLrQ@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, fupanli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org List-Id: linux-efi@vger.kernel.org On Tue, 04 Aug, at 09:51:21AM, fupan.li-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org wrote: > From: Fupan Li > > Commit 35d5134b7d5a > ("x86/efi: Correct EFI boot stub use of code32_start") > imported a bug, which will cause 32bit kernel boot failed > using efi method. It should use the label's address instead > of the value stored in the label to caculate the address of > code32_start. > > Signed-off-by: Fupan Li > --- > arch/x86/boot/compressed/head_32.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Matt Fleming -- Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754756AbbHDRNC (ORCPT ); Tue, 4 Aug 2015 13:13:02 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:38268 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752415AbbHDRM7 (ORCPT ); Tue, 4 Aug 2015 13:12:59 -0400 Date: Tue, 4 Aug 2015 18:12:56 +0100 From: Matt Fleming To: fupan.li@windriver.com Cc: gregkh@linuxfoundation.org, jslaby@suse.cz, linux-efi@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, fupanli@gmail.com, ben@decadent.org.uk Subject: Re: [PATCH V3 request from stable 3.10 to 3.14] efi: fix 32bit kernel boot failed problem using efi Message-ID: <20150804171256.GA4332@codeblueprint.co.uk> References: <1438653081-25746-1-git-send-email-fupan.li@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438653081-25746-1-git-send-email-fupan.li@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 04 Aug, at 09:51:21AM, fupan.li@windriver.com wrote: > From: Fupan Li > > Commit 35d5134b7d5a > ("x86/efi: Correct EFI boot stub use of code32_start") > imported a bug, which will cause 32bit kernel boot failed > using efi method. It should use the label's address instead > of the value stored in the label to caculate the address of > code32_start. > > Signed-off-by: Fupan Li > --- > arch/x86/boot/compressed/head_32.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Matt Fleming -- Matt Fleming, Intel Open Source Technology Center