From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 7/9] zmqpp: update to use the gcc version dependency mechanism
Date: Tue, 4 Aug 2015 22:12:58 +0200 [thread overview]
Message-ID: <20150804201258.GZ3647@free.fr> (raw)
In-Reply-To: <1438711241-31792-8-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2015-08-04 20:00 +0200, Thomas Petazzoni spake thusly:
> This commit updates the zmqpp Config.in file to use the newly
> introduced gcc version dependency mechanism to depend on gcc >= 4.6
> instead of open-coding dependencies on specific toolchains.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> package/zmqpp/Config.in | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/package/zmqpp/Config.in b/package/zmqpp/Config.in
> index 0aaeda3..756c810 100644
> --- a/package/zmqpp/Config.in
> +++ b/package/zmqpp/Config.in
> @@ -1,10 +1,7 @@
> config BR2_PACKAGE_ZMQPP
> bool "zmqpp"
> - depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc
> - depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Too old gcc
> - depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Too old gcc
> - depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201103 # c++0x support
> - depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201009 # c++0x support
> + # c++0x support
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_6
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_USE_WCHAR # util-linux
> depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq
> @@ -17,9 +14,9 @@ config BR2_PACKAGE_ZMQPP
>
> http://github.com/benjamg/zmqpp
>
> -comment "zmqpp needs a toolchain w/ C++, wchar, threads"
> +comment "zmqpp needs a toolchain w/ C++, wchar, threads, gcc >= 4.6"
> depends on !(BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR && \
> - BR2_TOOLCHAIN_HAS_THREADS)
> + BR2_TOOLCHAIN_HAS_THREADS && BR2_TOOLCHAIN_GCC_AT_LEAST_4_6)
Don;t you want to take that opportunity to rewrite that with the more
usual !foo || !bar || !buz syntax?
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> if BR2_PACKAGE_ZMQPP
>
> --
> 2.5.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-08-04 20:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 18:00 [Buildroot] [PATCH 0/9] Add gcc version dependency mechanism Thomas Petazzoni
2015-08-04 18:00 ` [Buildroot] [PATCH 1/9] toolchain: add common gcc version hidden config options Thomas Petazzoni
2015-08-04 19:12 ` Yann E. MORIN
2015-08-04 18:00 ` [Buildroot] [PATCH 2/9] gcc: select the appropriate BR2_TOOLCHAIN_GCC_AT_LEAST_* option Thomas Petazzoni
2015-08-04 19:14 ` Yann E. MORIN
2015-08-04 18:00 ` [Buildroot] [PATCH 3/9] toolchain-external: add support for gcc version dependency Thomas Petazzoni
2015-08-04 19:49 ` Yann E. MORIN
2015-08-05 10:14 ` Thomas Petazzoni
2015-08-08 12:23 ` Jörg Krause
2015-08-08 12:33 ` Thomas Petazzoni
[not found] ` <1485266737.8272514.1439293774884.JavaMail.zimbra@datacom.ind.br>
[not found] ` <979955045.8284402.1439295583830.JavaMail.zimbra@datacom.ind.br>
2015-08-12 8:30 ` Thomas Petazzoni
2015-08-04 18:00 ` [Buildroot] [PATCH 4/9] docs/manual: document gcc version dependencies Thomas Petazzoni
2015-08-04 19:58 ` Yann E. MORIN
2015-08-05 9:05 ` Thomas Petazzoni
2015-08-05 19:53 ` Yann E. MORIN
2015-08-04 18:00 ` [Buildroot] [PATCH 5/9] libsigrok: depends on gcc >= 4.7 Thomas Petazzoni
2015-08-04 20:08 ` Yann E. MORIN
2015-08-05 7:56 ` Thomas Petazzoni
2015-08-04 18:00 ` [Buildroot] [PATCH 6/9] upmpdcli: update to use the gcc version dependency mechanism Thomas Petazzoni
2015-08-04 20:11 ` Yann E. MORIN
2015-08-04 18:00 ` [Buildroot] [PATCH 7/9] zmqpp: " Thomas Petazzoni
2015-08-04 20:12 ` Yann E. MORIN [this message]
2015-08-05 10:15 ` Thomas Petazzoni
2015-08-04 18:00 ` [Buildroot] [PATCH 8/9] libupnpp: " Thomas Petazzoni
2015-08-04 20:21 ` Yann E. MORIN
2015-08-04 18:00 ` [Buildroot] [PATCH 9/9] mpd: " Thomas Petazzoni
2015-08-04 20:22 ` Yann E. MORIN
2015-08-05 10:13 ` [Buildroot] [PATCH 0/9] Add " Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804201258.GZ3647@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.