Re: [PATCH for-next V7 2/6] IB/uverbs: Fix race between ib_uverbs_open and remove_one

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Tue, Aug 04, 2015 at 05:03:24PM +0300, Yishai Hadas wrote:

> Signed-off-by: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Shachar Raindel <raindel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>  drivers/infiniband/core/uverbs.h      |    3 +-
>  drivers/infiniband/core/uverbs_main.c |   43 +++++++++++++++++++++++----------
>  2 files changed, 32 insertions(+), 14 deletions(-)

This looks OK

Reviewed-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>

> @@ -798,6 +806,7 @@ static int ib_uverbs_open(struct inode *inode, struct file *filp)
>  	mutex_init(&file->mutex);
>  
>  	filp->private_data = file;
> +	kobject_get(&dev->kobj);

Minor quibble, this and the matching put can be dropped. Seeing
container_of followed by a get with out a copy is a red flag to anyone
reading this code.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html