From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: stmmac: add ipq806x glue layer
Date: Tue, 04 Aug 2015 22:49:59 +0000 [thread overview]
Message-ID: <20150804224959.GZ5096@mwanda> (raw)
On Tue, Aug 04, 2015 at 03:42:51PM -0700, Mathieu Olivari wrote:
> Hi Dan,
> You're right, that's a bug. The offset should be (x), and not (1 << x).
> We could either redefine the macro to be (x), or we just use << gmac->id
> directly without a macro.
> The reason why we have NSS_COMMON_CLK_SRC_CTRL_RGMII &
> NSS_COMMON_CLK_SRC_CTRL_SGMII macros is that the bit takes different values
> depending on the port. I can post a patch today if you want.
Yes, please. If you could give me a Reported-by: Dan Carpenter
<dan.carpenter@oracle.com> tag, I would be grateful. Thanks!
regards,
dan carpenter
next reply other threads:[~2015-08-04 22:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 22:49 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-30 19:12 stmmac: add ipq806x glue layer Dan Carpenter
2015-06-02 10:03 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804224959.GZ5096@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.