All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
	linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	John Kacur <jkacur@redhat.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	<stable-rt@vger.kernel.org>
Subject: [PATCH RT 6/7] kernel/irq_work: fix non RT case
Date: Tue, 04 Aug 2015 21:18:32 -0400	[thread overview]
Message-ID: <20150805011853.189005577@goodmis.org> (raw)
In-Reply-To: 20150805011826.881627614@goodmis.org

[-- Attachment #1: 0006-kernel-irq_work-fix-non-RT-case.patch --]
[-- Type: text/plain, Size: 999 bytes --]

3.18.18-rt16-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

After the deadlock fixed, the checked got somehow away and broke the non-RT
case which could invoke IRQ-work from softirq context.

Cc: stable-rt@vger.kernel.org
Reported-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/time/timer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/time/timer.c b/kernel/time/timer.c
index a29ab1a17023..3a978d000fce 100644
--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -1452,7 +1452,8 @@ void update_process_times(int user_tick)
 	rcu_check_callbacks(cpu, user_tick);
 
 #if defined(CONFIG_IRQ_WORK) && !defined(CONFIG_PREEMPT_RT_FULL)
-	irq_work_tick();
+	if (in_irq())
+		irq_work_tick();
 #endif
 	run_posix_cpu_timers(p);
 }
-- 
2.1.4



  parent reply	other threads:[~2015-08-05  1:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05  1:18 [PATCH RT 0/7] Linux 3.18.18-rt16-rc1 Steven Rostedt
2015-08-05  1:18 ` [PATCH RT 1/7] Revert "slub: delay ctor until the object is requested" Steven Rostedt
2015-08-05  1:18 ` [PATCH RT 2/7] mm/slub: move slab initialization into irq enabled region Steven Rostedt
2015-08-10  6:33   ` Mike Galbraith
2015-08-05  1:18 ` [PATCH RT 3/7] sched: Implement lockless wake-queues Steven Rostedt
2015-08-05  1:18 ` [PATCH RT 4/7] futex: Implement lockless wakeups Steven Rostedt
2015-08-05  1:18 ` [PATCH RT 5/7] ipc/mqueue: Implement lockless pipelined wakeups Steven Rostedt
2015-08-05  1:18 ` Steven Rostedt [this message]
2015-08-05  1:18 ` [PATCH RT 7/7] Linux 3.18.18-rt16-rc1 Steven Rostedt
2015-08-07  8:47 ` [PATCH RT 0/7] " Wolfgang M. Reimer
2015-08-07 13:48   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150805011853.189005577@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=C.Emde@osadl.org \
    --cc=bigeasy@linutronix.de \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=stable-rt@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.