From: Clemens Gruber <clemens.gruber@pqgruber.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Do not mux and setup SPI if disabled in the config
Date: Wed, 5 Aug 2015 10:33:34 +0200 [thread overview]
Message-ID: <20150805083334.GA25399@pqgruber.com> (raw)
In-Reply-To: <CAD6G_RSACEreaOsKWaEgPP7gZ-+jEoWDSCBmTM2VybuCUpPJ+w@mail.gmail.com>
On Wed, Aug 05, 2015 at 01:46:42PM +0530, Jagan Teki wrote:
> On 5 August 2015 at 13:35, Stefan Roese <sr@denx.de> wrote:
> > How about this patch:
> >
> > diff --git a/board/tqc/tqma6/tqma6.c b/board/tqc/tqma6/tqma6.c
> > index 29db838..345930f 100644
> > --- a/board/tqc/tqma6/tqma6.c
> > +++ b/board/tqc/tqma6/tqma6.c
> > @@ -28,6 +28,13 @@
> >
> > #include "tqma6_bb.h"
> >
> > +#ifndef CONFIG_SF_DEFAULT_BUS
> > +#define CONFIG_SF_DEFAULT_BUS 0
> > +#endif
> > +#ifndef CONFIG_SF_DEFAULT_CS
> > +#define CONFIG_SF_DEFAULT_CS 0
> > +#endif
>
> Why would need this - it's already part of spi_flash.h
I am also wondering about commit f85764cc1f6ab01ffc60dd78de9c4de4cff2b5ce, which
defines CONFIG_SPI_FLASH in the WRU4 defconfig file, even though it does not
need SPI flash support, just to work around undefined reference errors regarding
spi_flash_free, etc.
Couldn't those workarounds be avoided by excluding the SPI parts via ifdefs, as
I did in my patch today?
>
> >
> > Does this work for you?
>
> thanks!
> --
> Jagan | openedev.
Thanks,
Clemens
next prev parent reply other threads:[~2015-08-05 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 17:28 [U-Boot] [PATCH] Do not mux and setup SPI if disabled in the config Clemens Gruber
2015-08-05 5:19 ` Stefan Roese
2015-08-05 7:28 ` Clemens Gruber
2015-08-05 8:05 ` Stefan Roese
2015-08-05 8:16 ` Jagan Teki
2015-08-05 8:33 ` Clemens Gruber [this message]
2015-08-05 8:37 ` Stefan Roese
2015-08-05 8:17 ` Clemens Gruber
2015-08-05 8:36 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805083334.GA25399@pqgruber.com \
--to=clemens.gruber@pqgruber.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.