All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	grygorii.strashko@ti.com, nsekhar@ti.com, stable@vger.kernel.org,
	Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator
Date: Wed, 5 Aug 2015 02:47:18 -0700	[thread overview]
Message-ID: <20150805094717.GX16878@atomide.com> (raw)
In-Reply-To: <1437996250-2913-2-git-send-email-kishon@ti.com>

* Kishon Vijay Abraham I <kishon@ti.com> [150727 04:27]:
> vsel_reg and enable_reg of the pbias regulator descriptor should actually
> have the offset from syscon. However after the pbias device tree node
> is moved as a child node of syscon, vsel_reg and enable_reg has the
> absolute address because of the address translation that happens while
> creating device from device tree node.
> So avoid using platform_get_resource and use of_get_address in order to
> get only the offset (untranslated address) and populate these in
> vsel_reg and enable_reg.

I think this gets fixed automatically with your other series
adding the "simple-bus" to the nodes. For the children of_ioremap
and friends should do the right thing, but without help from the bus
things won't work right without "simple-bus".

Regards,

Tony

  parent reply	other threads:[~2015-08-05  9:47 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 11:24 [PATCH 0/2] pbias regulator fixes Kishon Vijay Abraham I
2015-07-27 11:24 ` Kishon Vijay Abraham I
2015-07-27 11:24 ` [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator Kishon Vijay Abraham I
2015-07-27 11:24   ` Kishon Vijay Abraham I
2015-07-29  8:57   ` Grygorii Strashko
2015-07-29  8:57     ` Grygorii Strashko
2015-08-05  9:47   ` Tony Lindgren [this message]
2015-08-05 14:56     ` Kishon Vijay Abraham I
2015-08-05 14:56       ` Kishon Vijay Abraham I
2015-08-06  6:26       ` Tony Lindgren
2015-08-06  9:58         ` Grygorii Strashko
2015-08-06  9:58           ` Grygorii Strashko
2015-08-14 18:00   ` Mark Brown
2015-08-18  5:53     ` Kishon Vijay Abraham I
2015-08-18  5:53       ` Kishon Vijay Abraham I
2015-08-19 18:11       ` Mark Brown
2015-08-20  5:51         ` Kishon Vijay Abraham I
2015-08-20  5:51           ` Kishon Vijay Abraham I
2015-08-20 17:42           ` Mark Brown
2015-08-25 10:03         ` Grygorii Strashko
2015-08-25 10:03           ` Grygorii Strashko
2015-08-25 13:50           ` Mark Brown
2015-08-31 10:44             ` Kishon Vijay Abraham I
2015-08-31 10:44               ` Kishon Vijay Abraham I
2015-08-31 14:52               ` Mark Brown
2015-09-01  9:40                 ` Kishon Vijay Abraham I
2015-09-01  9:40                   ` Kishon Vijay Abraham I
2015-09-01 11:31                   ` Kishon Vijay Abraham I
2015-09-01 11:31                     ` Kishon Vijay Abraham I
2015-09-01 14:17                   ` Tony Lindgren
2015-09-01 18:36                     ` Mark Brown
2015-09-01 18:56                       ` Tony Lindgren
2015-09-02 11:15                         ` Mark Brown
2015-07-27 11:24 ` [PATCH 2/2] regulator: pbias: Fix broken pbias disable functionality Kishon Vijay Abraham I
2015-07-27 11:24   ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150805094717.GX16878@atomide.com \
    --to=tony@atomide.com \
    --cc=broonie@kernel.org \
    --cc=grygorii.strashko@ti.com \
    --cc=kishon@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=stable@vger.kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.