From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751495AbbHEH4O (ORCPT ); Wed, 5 Aug 2015 03:56:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49498 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751222AbbHEH4L (ORCPT ); Wed, 5 Aug 2015 03:56:11 -0400 Date: Wed, 5 Aug 2015 10:56:08 +0300 From: "Michael S. Tsirkin" To: Jason Wang Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kraxel@redhat.com Subject: Re: [PATCH] virtio-input: reset device during remove Message-ID: <20150805104654-mutt-send-email-mst@redhat.com> References: <1438759218-30038-1-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438759218-30038-1-git-send-email-jasowang@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 05, 2015 at 03:20:18PM +0800, Jason Wang wrote: > Spec requires a device reset during cleanup, so do it and avoid warn > in virtio core. > > Signed-off-by: Jason Wang OK but now that I look at this driver, that's not enough. Need to also detach and free unused buffers, otherwise we leak memory in evt and sts queues. > --- > drivers/virtio/virtio_input.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c > index 60e2a16..6222f9b 100644 > --- a/drivers/virtio/virtio_input.c > +++ b/drivers/virtio/virtio_input.c > @@ -320,6 +320,7 @@ static void virtinput_remove(struct virtio_device *vdev) > spin_unlock_irqrestore(&vi->lock, flags); > > input_unregister_device(vi->idev); > + vdev->config->reset(vdev); > vdev->config->del_vqs(vdev); > kfree(vi); > } > -- > 2.1.4