All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Tom Herbert <tom@herbertland.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Anjali Singhai Jain <anjali.singhai@intel.com>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	<nhorman@redhat.com>, <sassmann@redhat.com>,
	<jogreene@redhat.com>,
	Catherine Sullivan <catherine.sullivan@intel.com>,
	jesse.brandeburg@intel.com
Subject: Re: [net-next 07/15] i40e/i40evf: Add TX/RX outer UDP checksum support for X722
Date: Wed, 5 Aug 2015 17:38:30 -0700	[thread overview]
Message-ID: <20150805173830.00001a1c@unknown> (raw)
In-Reply-To: <CALx6S37TdC_ykVSi2SfLpX8TyNDs+XAgOxQzxgK-x8dKzb_nAA@mail.gmail.com>

On Wed, 5 Aug 2015 17:13:21 -0700
Tom Herbert <tom@herbertland.com> wrote:

> On Wed, Aug 5, 2015 at 4:52 PM, Jeff Kirsher
> <jeffrey.t.kirsher@intel.com> wrote:
> > From: Anjali Singhai Jain <anjali.singhai@intel.com>
> >                 if (vsi->back->flags & I40E_FLAG_WB_ON_ITR_CAPABLE)
> >                         tx_ring->flags = I40E_TXR_FLAGS_WB_ON_ITR;
> > +               if (vsi->back->flags & I40E_FLAG_OUTER_UDP_CSUM_CAPABLE)
> > +                       tx_ring->flags |= I40E_TXR_FLAGS_OUTER_UDP_CSUM;
> 
> Just curious... is there a difference between enabling the outer UDP
> checksum (of a tunnel) and just enabling checksum offload for UDP
> packets?

Yes, the hardware knows the difference (or we actually tell it
the difference) between a UDP packet and a tunnel inside a UDP
packet.

  reply	other threads:[~2015-08-06  0:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05 23:52 [net-next 00/15][pull request] Intel Wired LAN Driver Updates 2015-08-05 Jeff Kirsher
2015-08-05 23:52 ` [net-next 01/15] i40e/i40evf: Add device ids for X722 Jeff Kirsher
2015-08-05 23:52 ` [net-next 02/15] i40e/i40evf: Add flags for X722 capabilities Jeff Kirsher
2015-08-05 23:52 ` [net-next 03/15] i40e/i40evf: Update FW API with X722 support Jeff Kirsher
2015-08-05 23:52 ` [net-next 04/15] i40e/i40evf: Update register.h file for X722 Jeff Kirsher
2015-08-05 23:52 ` [net-next 05/15] i40e/i40evf: RSS changes " Jeff Kirsher
2015-08-05 23:52 ` [net-next 06/15] i40e/i40evf: Add support for writeback on ITR feature " Jeff Kirsher
2015-08-05 23:52 ` [net-next 07/15] i40e/i40evf: Add TX/RX outer UDP checksum support " Jeff Kirsher
2015-08-06  0:13   ` Tom Herbert
2015-08-06  0:38     ` Jesse Brandeburg [this message]
2015-08-06 15:12       ` Tom Herbert
2015-08-05 23:52 ` [net-next 08/15] i40e: Add IWARP " Jeff Kirsher
2015-08-05 23:52 ` [net-next 09/15] i40e/i40evf: Add ATR HW eviction " Jeff Kirsher
2015-08-05 23:52 ` [net-next 10/15] i40e: Add AQ commands for NVM Update " Jeff Kirsher
2015-08-05 23:52 ` [net-next 11/15] e1000e: Fix EEE in Sx implementation Jeff Kirsher
2015-08-05 23:52 ` [net-next 12/15] e1000e: Cosmetic changes Jeff Kirsher
2015-08-05 23:52 ` [net-next 13/15] e1000e: Fix incorrect ASPM locking Jeff Kirsher
2015-08-05 23:52 ` [net-next 14/15] e1000e: Fix tight loop implementation of systime read algorithm Jeff Kirsher
2015-08-05 23:52 ` [net-next 15/15] e1000e: Increase driver version number Jeff Kirsher
2015-08-07  7:19 ` [net-next 00/15][pull request] Intel Wired LAN Driver Updates 2015-08-05 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150805173830.00001a1c@unknown \
    --to=jesse.brandeburg@intel.com \
    --cc=anjali.singhai@intel.com \
    --cc=catherine.sullivan@intel.com \
    --cc=davem@davemloft.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jogreene@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.