Re: [PATCH 001/001] perf: let trace write to stderr by default

[Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>]

Em Wed, Aug 05, 2015 at 04:50:06PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Aug 04, 2015 at 07:14:22PM +0200, Milian Wolff escreveu:
> > On Tuesday 04 August 2015 13:50:14 Arnaldo Carvalho de Melo wrote:
> > > Le 4 août 2015 1:46 PM, "Milian Wolff" <mail@milianw.de> a écrit :
> > > > See attached trivial patch which brings trace a bit closer to strace.
> > > > 
> > > > I've never published a patch to the Kernel yet, I hope it's OK as-is. I
> > > 
> > > can
> > > 
> > > > amend it at will if you have any requests to the style
> > > 
> > > Start by not using attachments :-)
> > 
> > :)
> 
> Second step, read Documentation/email-clients.txt, you are using Kmail
> and it is mangling the patches, I'll apply the patch by hand this time.

And don't forget to read Documentation/SubmittingPatches, you forgot the
Signed-off-by part as well. It is simple stuff, so I'll not add it, keep
your authorship and sign it off myself.
 
> - Arnaldo
>  
> > >From 188476d65bab17ad99f5bdf65294160ef2d5f49b Mon Sep 17 00:00:00 2001
> > From: Milian Wolff <milian.wolff@kdab.com>
> > Date: Tue, 4 Aug 2015 18:30:52 +0200
> > Subject: [PATCH] perf: let trace write to stderr by default
> > 
> > Without this patch, it is cumbersome to read the trace output
> > but ignoring the normal, potentially verbose, output of the debuggee.
> > One common example is doing something like the following:
> > 
> > perf trace -s find /tmp > /dev/null
> > 
> > Without this patch, the trace summary will be lost. Now, it will
> > still be printed at the end. This behavior is also applied by strace.
> > ---
> >  tools/perf/builtin-trace.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> > index 39ad4d0..d183d88 100644
> > --- a/tools/perf/builtin-trace.c
> > +++ b/tools/perf/builtin-trace.c
> > @@ -2778,7 +2778,7 @@ int cmd_trace(int argc, const char **argv, const char 
> > *prefix __maybe_unused)
> >  			.mmap_pages    = UINT_MAX,
> >  			.proc_map_timeout  = 500,
> >  		},
> > -		.output = stdout,
> > +		.output = stderr,
> >  		.show_comm = true,
> >  		.trace_syscalls = true,
> >  	};
> > -- 
> > 2.5.0
> > 
> > -- 
> > Milian Wolff
> > mail@milianw.de
> > http://milianw.de