From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753485AbbHEUkW (ORCPT ); Wed, 5 Aug 2015 16:40:22 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37758 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752744AbbHEUkU (ORCPT ); Wed, 5 Aug 2015 16:40:20 -0400 Date: Wed, 5 Aug 2015 13:40:20 -0700 From: "gregkh@linuxfoundation.org" To: Philip Moltmann Cc: "dmitry.torokhov@gmail.com" , "linux-kernel@vger.kernel.org" , "pv-drivers@vmware.com" , Xavier Deguillard , John Savanyo , "akpm@linux-foundation.org" Subject: Re: [PATCH v3 5/9] VMware balloon: Show capabilities of balloon and resulting capabilities in the debug-fs node. Message-ID: <20150805204020.GB16746@kroah.com> References: <20150612161513.GA23859@dtor-pixel> <1434134610-2831-6-git-send-email-moltmann@vmware.com> <20150805201459.GA16009@kroah.com> <1438806166.31263.203.camel@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438806166.31263.203.camel@vmware.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 05, 2015 at 08:22:35PM +0000, Philip Moltmann wrote: > Hi, > > > > MODULE_AUTHOR("VMware, Inc."); > > > MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver"); > > > -MODULE_VERSION("1.3.2.0-k"); > > > +MODULE_VERSION("1.3.3.0-k"); > > > > This constant change of module version is annoying, is it really even > > needed? > > > > I'll take this, but seriously consider just dropping it entirely as > > it > > doesn't mean anything now that the driver is in the kernel tree. > > I think this is meant so that we can track which patches got backported > into RHEL and SLES. That guarantees all of those patches will conflict and the engineers will curse your name. Don't do that, it's horrid. What happens if someone picks one patch, and then skips one, and uses the third? What would be the "version" then? Just drop it entirely, it's useless. You have the source, so you know what changes are done, no need to try to match it up with a random number. greg k-h