All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Cody <jcody@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block/mirror: limit qiov to IOV_MAX elements
Date: Thu, 6 Aug 2015 04:50:17 -0400	[thread overview]
Message-ID: <20150806085017.GE9878@localhost.localdomain> (raw)
In-Reply-To: <1435761950-26714-1-git-send-email-stefanha@redhat.com>

On Wed, Jul 01, 2015 at 03:45:50PM +0100, Stefan Hajnoczi wrote:
> If mirror has more free buffers than IOV_MAX, preadv(2)/pwritev(2)
> EINVAL failures may be encountered.
> 
> It is possible to trigger this by setting granularity to a low value
> like 8192.
> 
> This patch stops appending chunks once IOV_MAX is reached.
> 
> The spurious EINVAL failure can be reproduced with a qcow2 image file
> and the following QMP invocation:
> 
>   qmp.command('drive-mirror', device='virtio0', target='/tmp/r7.s1',
>               granularity=8192, sync='full', mode='absolute-paths',
>               format='raw')
> 
> While the guest is running dd if=/dev/zero of=/var/tmp/foo oflag=direct
> bs=4k.
> 

Thanks,

Applied to my 'block-next' branch:

https://github.com/codyprime/qemu-kvm-jtc/tree/block-next

-Jeff

      parent reply	other threads:[~2015-08-06  8:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01 14:45 [Qemu-devel] [PATCH] block/mirror: limit qiov to IOV_MAX elements Stefan Hajnoczi
2015-07-01 14:47 ` Paolo Bonzini
2015-07-01 14:59   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-07-01 15:03     ` Paolo Bonzini
2015-07-01 16:05       ` Stefan Hajnoczi
2015-07-08 11:14 ` Kevin Wolf
2015-07-08 12:34   ` Stefan Hajnoczi
2015-08-04 16:13 ` Stefan Hajnoczi
2015-08-06  8:50 ` Jeff Cody [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150806085017.GE9878@localhost.localdomain \
    --to=jcody@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.