From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756209AbbHGCKM (ORCPT ); Thu, 6 Aug 2015 22:10:12 -0400 Received: from mail.kernel.org ([198.145.29.136]:48719 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755354AbbHGCAE (ORCPT ); Thu, 6 Aug 2015 22:00:04 -0400 Date: Thu, 6 Aug 2015 16:50:10 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Jiri Olsa Subject: Re: [PATCH V8 11/25] perf auxtrace: Fix period type 'i' not working Message-ID: <20150806195010.GD10826@kernel.org> References: <1437150840-31811-1-git-send-email-adrian.hunter@intel.com> <1437150840-31811-12-git-send-email-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437150840-31811-12-git-send-email-adrian.hunter@intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Jul 17, 2015 at 07:33:46PM +0300, Adrian Hunter escreveu: > PERF_ITRACE_PERIOD_INSTRUCTIONS is zero so it > got overwritten by the default period type. > Fix by checking if the period type was set > rather than if the value was zero when applying > the default. Applied > Signed-off-by: Adrian Hunter > --- > tools/perf/util/auxtrace.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c > index 3f3b40fa87c8..4ec3acf6fabb 100644 > --- a/tools/perf/util/auxtrace.c > +++ b/tools/perf/util/auxtrace.c > @@ -949,6 +949,7 @@ int itrace_parse_synth_opts(const struct option *opt, const char *str, > struct itrace_synth_opts *synth_opts = opt->value; > const char *p; > char *endptr; > + bool period_type_set = false; > > synth_opts->set = true; > > @@ -977,10 +978,12 @@ int itrace_parse_synth_opts(const struct option *opt, const char *str, > case 'i': > synth_opts->period_type = > PERF_ITRACE_PERIOD_INSTRUCTIONS; > + period_type_set = true; > break; > case 't': > synth_opts->period_type = > PERF_ITRACE_PERIOD_TICKS; > + period_type_set = true; > break; > case 'm': > synth_opts->period *= 1000; > @@ -993,6 +996,7 @@ int itrace_parse_synth_opts(const struct option *opt, const char *str, > goto out_err; > synth_opts->period_type = > PERF_ITRACE_PERIOD_NANOSECS; > + period_type_set = true; > break; > case '\0': > goto out; > @@ -1046,7 +1050,7 @@ int itrace_parse_synth_opts(const struct option *opt, const char *str, > } > out: > if (synth_opts->instructions) { > - if (!synth_opts->period_type) > + if (!period_type_set) > synth_opts->period_type = > PERF_ITRACE_DEFAULT_PERIOD_TYPE; > if (!synth_opts->period) > -- > 1.9.1