From: Peter Zijlstra <peterz@infradead.org>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: Matthew Leach <matthew@mattleach.net>,
Ingo Molnar <mingo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"eranian@google.com" <eranian@google.com>,
'Andi Kleen' <ak@linux.intel.com>,
'Bjorn Helgaas' <bhelgaas@google.com>,
'Vince Weaver' <vincent.weaver@maine.edu>,
'Sonny Rao' <sonnyrao@chromium.org>
Subject: Re: [BUG]: Intel uncore boot warning introduced in 4.1
Date: Fri, 07 Aug 2015 09:05:53 +0000 [thread overview]
Message-ID: <20150807090553.GC16853@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077018D32C2@SHSMSX103.ccr.corp.intel.com>
On Thu, Aug 06, 2015 at 06:10:40PM +0000, Liang, Kan wrote:
> The issue may be caused by uncore box initialization.
>
> For preventing the potential issues of uncore box initialization, I once
> moved the uncore_box_init() out of driver initialization in commit
> c05199e5a57a579fea1e8fa65e2b511ceb524ffc.
>
> However, it cause some desktop crash, because the box initialization
> codes were moved in IPI context.
>
> For fixing the crash issue, we had two choice at that time.
> - Simply revert the codes. That's where is
> 15c1247953e8a45232ed5a5540f291d2d0a77665 from.
> - Move uncore_box_init out of IPI context to uncore event
> init. I provided a patch for it. https://lkml.org/lkml/2015/4/28/21
> Stephane Eranian also verified it on his platform
>
> At that time, we chose first option. But it looks there is some
> issue now. I guess we may try the second option this time.
>
> Matthew,
>
> Could you please revert
> 15c1247953e8a45232ed5a5540f291d2d0a77665
> and apply the patch https://lkml.org/lkml/2015/4/26/294?
> See if it works?
That patch is wrong though; how can even publish a PMU which is not
initialized?
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: Matthew Leach <matthew@mattleach.net>,
Ingo Molnar <mingo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"eranian@google.com" <eranian@google.com>,
"'Andi Kleen'" <ak@linux.intel.com>,
"'Bjorn Helgaas'" <bhelgaas@google.com>,
"'Vince Weaver'" <vincent.weaver@maine.edu>,
"'Sonny Rao'" <sonnyrao@chromium.org>
Subject: Re: [BUG]: Intel uncore boot warning introduced in 4.1
Date: Fri, 7 Aug 2015 11:05:53 +0200 [thread overview]
Message-ID: <20150807090553.GC16853@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077018D32C2@SHSMSX103.ccr.corp.intel.com>
On Thu, Aug 06, 2015 at 06:10:40PM +0000, Liang, Kan wrote:
> The issue may be caused by uncore box initialization.
>
> For preventing the potential issues of uncore box initialization, I once
> moved the uncore_box_init() out of driver initialization in commit
> c05199e5a57a579fea1e8fa65e2b511ceb524ffc.
>
> However, it cause some desktop crash, because the box initialization
> codes were moved in IPI context.
>
> For fixing the crash issue, we had two choice at that time.
> - Simply revert the codes. That's where is
> 15c1247953e8a45232ed5a5540f291d2d0a77665 from.
> - Move uncore_box_init out of IPI context to uncore event
> init. I provided a patch for it. https://lkml.org/lkml/2015/4/28/21
> Stephane Eranian also verified it on his platform
>
> At that time, we chose first option. But it looks there is some
> issue now. I guess we may try the second option this time.
>
> Matthew,
>
> Could you please revert
> 15c1247953e8a45232ed5a5540f291d2d0a77665
> and apply the patch https://lkml.org/lkml/2015/4/26/294?
> See if it works?
That patch is wrong though; how can even publish a PMU which is not
initialized?
next prev parent reply other threads:[~2015-08-07 9:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 9:34 [BUG]: Intel uncore boot warning introduced in 4.1 Matthew Leach
2015-08-06 9:34 ` Matthew Leach
2015-08-06 16:13 ` Matthew Leach
2015-08-06 16:13 ` Matthew Leach
2015-08-06 18:10 ` Liang, Kan
2015-08-06 18:10 ` Liang, Kan
2015-08-06 18:44 ` Matthew Leach
2015-08-06 18:44 ` Matthew Leach
2015-08-07 9:05 ` Peter Zijlstra [this message]
2015-08-07 9:05 ` Peter Zijlstra
2015-08-10 13:23 ` Liang, Kan
2015-09-15 13:35 ` Josh Boyer
2015-09-15 13:35 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150807090553.GC16853@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@mattleach.net \
--cc=mingo@kernel.org \
--cc=sonnyrao@chromium.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.