All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Joonsoo Kim <js1304@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
	linux-kernel@vger.kernel.org,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH] zram: fix possible race when checking idle_strm
Date: Fri, 7 Aug 2015 18:38:09 +0900	[thread overview]
Message-ID: <20150807093809.GO1891@swordfish> (raw)
In-Reply-To: <20150807091928.GM1891@swordfish>

On (08/07/15 18:19), Sergey Senozhatsky wrote:
> [..]
> > hm... we also can simply forbid downgrading a multi stream backend
> > to a single stream (in terms of performance it is much slower
> > than a real single steam anyway). will this do the trick? if we
> > have more than 1 stream and idle list then there will be more that
> > one wakeup. and every woken up task will call wakeup once it put
> > stream.
> 
> this is unreadable, sorry.
> 
> should be:
> "if we have more than 1 stream and _empty_ idle list then there
> will be more than one wakeup. and every woken up task will call
> wakeup once it puts stream back to the idle list."

no, nevermind. I think it sucks.

	-ss

  reply	other threads:[~2015-08-07  9:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07  8:03 [PATCH] zram: fix possible race when checking idle_strm Joonsoo Kim
2015-08-07  9:14 ` Sergey Senozhatsky
2015-08-07  9:19   ` Sergey Senozhatsky
2015-08-07  9:38     ` Sergey Senozhatsky [this message]
2015-08-07  9:58   ` Sergey Senozhatsky
2015-08-10  0:32     ` Joonsoo Kim
2015-08-10  2:16       ` Sergey Senozhatsky
2015-08-11  8:26         ` Joonsoo Kim
2015-08-10 23:26       ` Minchan Kim
2015-08-11  8:25         ` Joonsoo Kim
2015-08-11  8:25           ` Sergey Senozhatsky
2015-08-07  9:37 ` Sergey Senozhatsky
2015-08-07 10:16   ` Sergey Senozhatsky
2015-08-07 14:49 ` Minchan Kim
2015-08-10  0:35   ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150807093809.GO1891@swordfish \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=js1304@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.