From mboxrd@z Thu Jan  1 00:00:00 1970
From: Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH] coredump: Replace opencoded set_mask_bits()
Date: Fri, 7 Aug 2015 13:57:10 +0200
Message-ID: <20150807115710.GA16897@redhat.com>
References: <1438935406-5762-1-git-send-email-vgupta@synopsys.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1438935406-5762-1-git-send-email-vgupta@synopsys.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On 08/07, Vineet Gupta wrote:
>
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -1690,15 +1690,10 @@ EXPORT_SYMBOL(set_binfmt);
>   */
>  void set_dumpable(struct mm_struct *mm, int value)
>  {
> -	unsigned long old, new;
> -
>  	if (WARN_ON((unsigned)value > SUID_DUMP_ROOT))
>  		return;
>  
> -	do {
> -		old = ACCESS_ONCE(mm->flags);
> -		new = (old & ~MMF_DUMPABLE_MASK) | value;
> -	} while (cmpxchg(&mm->flags, old, new) != old);
> +	set_mask_bits(&mm->flags, MMF_DUMPABLE_MASK, value);
>  }

Acked-by: Oleg Nesterov <oleg@redhat.com>