All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org,
	patchwork-lst@pengutronix.de
Subject: Re: [PATCH 2/2] drm/panel: correct minimum hsync length of the HannStar HSD070PWW1 panel
Date: Fri, 7 Aug 2015 14:43:17 +0200	[thread overview]
Message-ID: <20150807124316.GD25792@ulmo> (raw)
In-Reply-To: <1435314429-10511-2-git-send-email-l.stach@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 1351 bytes --]

On Fri, Jun 26, 2015 at 12:27:09PM +0200, Lucas Stach wrote:
> From: Philipp Zabel <p.zabel@pengutronix.de>
> 
> According to the data sheet, the minimum horizontal blanking interval
> is 54 clocks (1 + 52 + 1), but tests with a Nitrogen6X have shown the
> minimum working horizontal blanking interval to be 60 clocks.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index dc6a923c89d7..7196b940a928 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -713,7 +713,12 @@ static const struct display_timing hannstar_hsd070pww1_timing = {
>  	.hactive = { 1280, 1280, 1280 },
>  	.hfront_porch = { 1, 1, 10 },
>  	.hback_porch = { 1, 1, 10 },
> -	.hsync_len = { 52, 158, 661 },
> +	/*
> +	 * According to the data sheet, the minimum horizontal blanking interval
> +	 * is 54 clocks (1 + 52 + 1), but tests with a Nitrogen6X have shown the
> +	 * minimum working horizontal blanking interval to be 60 clocks.
> +	 */
> +	.hsync_len = { 58, 158, 661 },

58 != 60, so which one is the truth here?

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-08-07 12:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-26 10:27 [PATCH 1/2] drm/panel: simple: Add bus format for HannStar HSD070PWW1 LVDS panel Lucas Stach
2015-06-26 10:27 ` [PATCH 2/2] drm/panel: correct minimum hsync length of the HannStar HSD070PWW1 panel Lucas Stach
2015-08-07 12:43   ` Thierry Reding [this message]
2015-08-07 12:48     ` Lucas Stach
2015-07-23 14:45 ` [PATCH 1/2] drm/panel: simple: Add bus format for HannStar HSD070PWW1 LVDS panel Lucas Stach
2015-08-07 12:31   ` Lucas Stach
2015-08-07 12:42 ` Thierry Reding
2015-08-07 13:06   ` Philipp Zabel
2015-08-07 13:22     ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150807124316.GD25792@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=patchwork-lst@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.