All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Peter Chen <peter.chen@freescale.com>,
	Felipe Balbi <balbi@ti.com>, Mark Brown <broonie@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	sojka@merica.cz, Alan Stern <stern@rowland.harvard.edu>,
	andreas@gaisler.com, linux-usb@vger.kernel.org,
	device-mainlining@lists.linuxfoundation.org
Subject: Re: [PATCH 0/2] Introduce usb charger framework to deal with the usb gadget power negotation
Date: Fri, 7 Aug 2015 10:52:10 -0700	[thread overview]
Message-ID: <20150807175210.GC10003@kroah.com> (raw)
In-Reply-To: <CAMz4ku+a5mk=1i-gYXxkksudKxijgOHOmVati_4WB_OO+O+FWg@mail.gmail.com>

On Fri, Aug 07, 2015 at 04:19:40PM +0800, Baolin Wang wrote:
> On 7 August 2015 at 13:34, Peter Chen <peter.chen@freescale.com> wrote:
> > On Thu, Aug 06, 2015 at 03:03:47PM +0800, Baolin Wang wrote:
> >> Currently the Linux kernel does not provide any standard integration of this
> >> feature that integrates the USB subsystem with the system power regulation
> >> provided by PMICs meaning that either vendors must add this in their kernels
> >> or USB gadget devices based on Linux (such as mobile phones) may not behave
> >> as they should.
> >>
> >> Providing a standard framework for doing this in the kernel.
> >
> > Baolin, thanks for introducing a framework for doing it, we do support
> > USB Charger for chipidea driver at internal tree, but it is specific
> > for imx, and still have some problems to upstream due to need to
> > change some common code.
> >
> > One suggestion, would you add your user next time? In that case, we can
> > know better for this framework.
> >
> 
> Peter, Thanks for your reviewing and comments. Now I just introduce
> the framework to review for more feedbacks and do not have a useful
> user to use it. I just can show you some example code to show how to
> use it. Thanks.

Without a real, in-tree user, I can not accept this code.  We don't add
"frameworks" for non-existant things, otherwise it will be instantly
ripped out the next kernel release.

Please come up with at least 2 users, ideally 3, otherwise there's no
real way to know if the framework is sufficient.

thanks,

greg k-h

  parent reply	other threads:[~2015-08-07 17:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-06  7:03 [PATCH 0/2] Introduce usb charger framework to deal with the usb gadget power negotation Baolin Wang
2015-08-06  7:03 ` [PATCH 1/2] gadget: Introduce the usb charger framework Baolin Wang
2015-08-06 16:39   ` Greg KH
2015-08-06 18:30     ` Mark Brown
2015-08-07  5:48     ` Baolin Wang
2015-08-07  5:41   ` Peter Chen
2015-08-07  8:33     ` Baolin Wang
2015-08-06  7:03 ` [PATCH 2/2] gadget: Support for " Baolin Wang
2015-08-07  5:45   ` Peter Chen
2015-08-07  8:46     ` Baolin Wang
2015-08-07  9:07       ` Peter Chen
2015-08-07  9:22         ` Baolin Wang
2015-08-07 17:53           ` Greg KH
2015-08-08  6:23             ` Baolin Wang
2015-08-06 16:21 ` [PATCH 0/2] Introduce usb charger framework to deal with the usb gadget power negotation Felipe Balbi
2015-08-06 16:39   ` Greg KH
2015-08-07  5:34 ` Peter Chen
2015-08-07  8:19   ` Baolin Wang
2015-08-07  8:31     ` Peter Chen
2015-08-07  8:47       ` Baolin Wang
2015-08-07 17:52     ` Greg KH [this message]
2015-08-08  6:22       ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150807175210.GC10003@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas@gaisler.com \
    --cc=balbi@ti.com \
    --cc=baolin.wang@linaro.org \
    --cc=broonie@kernel.org \
    --cc=device-mainlining@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.chen@freescale.com \
    --cc=sojka@merica.cz \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.