All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe MacDonald <joe@deserted.net>
To: wenzong fan <wenzong.fan@windriver.com>
Cc: yocto@yoctoproject.org
Subject: Re: [PATCH][meta-selinux] findutils/gnulib:drop the error output of 'ls' command
Date: Fri, 7 Aug 2015 15:46:19 -0400	[thread overview]
Message-ID: <20150807194619.GA13217@deserted.net> (raw)
In-Reply-To: <55B1FC87.2080807@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 3169 bytes --]

[Re: [yocto] [PATCH][meta-selinux] findutils/gnulib:drop the error output of 'ls' command] On 15.07.24 (Fri 16:51) wenzong fan wrote:

> Ping ...

This one clearly got lost in the mail somewhere (I'm working on making
sure that doesn't happen anymore) but it also doesn't look applicable to
the current findutils.  If it is, please re-submit it.

-J.

> 
> On 04/02/2015 10:26 AM, rongqing.li@windriver.com wrote:
> >From: Roy Li <rongqing.li@windriver.com>
> >
> >The ls command is used to check if the file exists, and it is normal that
> >the checked file does not exist, so drop the ls error ouput:
> >	 ls: cannot access ./doc/fdl.texi: No such file or directory
> >
> >Signed-off-by: Roy Li <rongqing.li@windriver.com>
> >---
> >  .../drop-the-error-output-of-ls-command.patch      | 29 ++++++++++++++++++++++
> >  .../findutils/findutils_4.4.2.bbappend             |  1 +
> >  2 files changed, 30 insertions(+)
> >  create mode 100644 recipes-extended/findutils/findutils-4.4.2/drop-the-error-output-of-ls-command.patch
> >
> >diff --git a/recipes-extended/findutils/findutils-4.4.2/drop-the-error-output-of-ls-command.patch b/recipes-extended/findutils/findutils-4.4.2/drop-the-error-output-of-ls-command.patch
> >new file mode 100644
> >index 0000000..069be41
> >--- /dev/null
> >+++ b/recipes-extended/findutils/findutils-4.4.2/drop-the-error-output-of-ls-command.patch
> >@@ -0,0 +1,29 @@
> >+[PATCH] drop the error output of 'ls' command
> >+
> >+Upstream-Status: pending
> >+
> >+ls is used to check if the file exists, and it is normal that
> >+the checked file does not exist, so drop the ls error
> >+	 ls: cannot access ./doc/fdl.texi: No such file or directory
> >+
> >+Signed-off-by: Roy Li <rongqing.li@windriver.com>
> >+---
> >+ gnulib-tool | 2 +-
> >+ 1 file changed, 1 insertion(+), 1 deletion(-)
> >+
> >+diff --git a/gnulib-tool b/gnulib-tool
> >+index 354b1f0..beb81ba 100755
> >+--- a/gnulib-tool
> >++++ b/gnulib-tool
> >+@@ -602,7 +602,7 @@ else
> >+   {
> >+     # Use two sed invocations. A single sed -n -e 's,^.* -> \(.*\)$,\1,p'
> >+     # would do the wrong thing if the link target contains " -> ".
> >+-    LC_ALL=C ls -l "$1" | sed -e 's, -> ,#%%#,' | sed -n -e 's,^.*#%%#\(.*\)$,\1,p'
> >++    LC_ALL=C ls -l "$1" 2>/dev/null | sed -e 's, -> ,#%%#,' | sed -n -e 's,^.*#%%#\(.*\)$,\1,p'
> >+   }
> >+ fi
> >+
> >+--
> >+1.9.1
> >+
> >diff --git a/recipes-extended/findutils/findutils_4.4.2.bbappend b/recipes-extended/findutils/findutils_4.4.2.bbappend
> >index 3245e5c..e174888 100644
> >--- a/recipes-extended/findutils/findutils_4.4.2.bbappend
> >+++ b/recipes-extended/findutils/findutils_4.4.2.bbappend
> >@@ -5,6 +5,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
> >  SRC_URI += "git://git.savannah.gnu.org/gnulib.git;protocol=git;rev=0e0635af0b23826911dc456bd0da40dcb19247de"
> >  SRC_URI += "file://findutils-with-selinux.patch"
> >  SRC_URI += "file://findutils-with-selinux-gnulib.patch"
> >+SRC_URI += "file://drop-the-error-output-of-ls-command.patch;patchdir=../git/"
> >
> >  inherit with-selinux
> >
> >
-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

      reply	other threads:[~2015-08-07 19:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02  2:26 [PATCH][meta-selinux] findutils/gnulib:drop the error output of 'ls' command rongqing.li
2015-07-08  2:55 ` wenzong fan
2015-07-24  8:51 ` wenzong fan
2015-08-07 19:46   ` Joe MacDonald [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150807194619.GA13217@deserted.net \
    --to=joe@deserted.net \
    --cc=wenzong.fan@windriver.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.