All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] [autobuild] package/elfutils: does not build with musl
Date: Sat, 8 Aug 2015 11:15:37 +0200	[thread overview]
Message-ID: <20150808111537.18bbf886@free-electrons.com> (raw)
In-Reply-To: <1438983471-26367-1-git-send-email-yann.morin.1998@free.fr>

Dear Yann E. MORIN,

On Fri,  7 Aug 2015 23:37:51 +0200, Yann E. MORIN wrote:

> diff --git a/package/elfutils/Config.in b/package/elfutils/Config.in
> index 6c6856e..19ab8fc 100644
> --- a/package/elfutils/Config.in
> +++ b/package/elfutils/Config.in
> @@ -1,6 +1,7 @@
> -comment "elfutils needs a toolchain w/ wchar, dynamic library"
> +comment "elfutils needs a uClibc or (e)glibc toolchain w/ wchar, dynamic library"
>  	depends on !BR2_bfin
>  	depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS
> +	depends on !BR2_TOOLCHAIN_USES_UCLIBC && !BR2_TOOLCHAIN_USES_GLIBC

Now that I read this again, I believe this is wrong. It should be:

	depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS \
		|| !(BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC)

with your version, the comment can only be visible when a toolchain
that is *not* uclibc and *not* glibc is used. I.e, the comment is now
only visible when musl is used. Which is not what we want.

Can you send a follow-up patch to fix this (I already pushed and
applied your patch).

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-08-08  9:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07 21:37 [Buildroot] [PATCH] [autobuild] package/elfutils: does not build with musl Yann E. MORIN
2015-08-08  8:56 ` Thomas Petazzoni
2015-08-08  9:15 ` Thomas Petazzoni [this message]
2015-08-08 18:38   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150808111537.18bbf886@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.