From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@intel.com>, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC V9 2/3] perf,tools: per-event callgraph support
Date: Sat, 8 Aug 2015 14:35:55 -0300 [thread overview]
Message-ID: <20150808173555.GC16520@kernel.org> (raw)
In-Reply-To: <20150808164539.GB17040@krava.brq.redhat.com>
Em Sat, Aug 08, 2015 at 06:45:39PM +0200, Jiri Olsa escreveu:
> On Fri, Aug 07, 2015 at 12:49:38PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Aug 07, 2015 at 12:38:43PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Thu, Aug 06, 2015 at 03:44:53PM -0400, kan.liang@intel.com escreveu:
> > > > From: Kan Liang <kan.liang@intel.com>
> > > > Here are some examples and test results.
> > > >
> > > > 1. Comparing the elapsed time and perf.data size from "kernbench -M -H".
> > > >
> > > > The test command for FULL callgraph and time support.
> > > > "perf record -e
> > > > '{cpu/cpu-cycles,period=100000/,cpu/instructions,period=20000/p}'
> > > > --call-graph fp --time"
> >
> > Some other oddity I noticed while testing:
> >
>
> SNIP
>
> > This is in the 'perf report' TUI, why, for an event with 'callgraph=no', we
> > get callchains? How come?
> >
> > If I try it with the --stdio, well, its there as well:
> >
> > # Samples: 2K of event 'cpu/instructions,call-graph=no,time=0,period=20000/p'
> > # Event count (approx.): 46956518
> > #
> > # Children Self Command Shared Object Symbol
> > # ........ ........ ............... .......................... ..............................................
> > #
> > 67.56% 0.00% qemu-system-x86 [unknown] [.] 0xad5e258d4c544155
> > |
> > ---0xad5e258d4c544155
> >
> > 67.56% 0.00% qemu-system-x86 libc-2.20.so [.] __libc_start_main
> > |
> > ---__libc_start_main
> > 0xad5e258d4c544155
> >
> > 67.56% 0.00% qemu-system-x86 perf [.] main
> > |
> > ---main
> > __libc_start_main
> > 0xad5e258d4c544155
> >
> > 67.56% 0.00% qemu-system-x86 perf [.] run_builtin
> > |
> > ---run_builtin
> > main
> > __libc_start_main
> > 0xad5e258d4c544155
> >
> > Can you take a look? What I have, i.e. the patches from Jiri and Kan
> > moving stuff out of the way of the python binding and this patch is at
> > the tmp.perf/core branch in my git tree:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
>
> hum, tried this branch and got proper behaviour for both stdio and TUI,
> attaching stdio output
>
> the record command was:
> $ ./perf record -e 'cpu/cpu-cycles,call-graph=fp,time,period=10000/pp,cpu/instructions,call-graph=no,time=0,period=20000/p' ls
>
> got the events strings from your report output.. what was different in your record command?
Was in my message, here it is:
# cmdline : /home/acme/bin/perf record -e {cpu/cpu-cycles,call-graph=fp,time,period=10000/pp,cpu/instructions,call-graph=no,time=0,period=20000/p}
-a
I'll try this again later.
- Arnaldo
next prev parent reply other threads:[~2015-08-08 17:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 19:44 [PATCH RFC V9 1/3] perf,tools: move callchain option parse code to util.c kan.liang
2015-08-06 19:44 ` [PATCH RFC V9 2/3] perf,tools: per-event callgraph support kan.liang
2015-08-07 10:54 ` Jiri Olsa
2015-08-07 15:38 ` Arnaldo Carvalho de Melo
2015-08-07 15:49 ` Arnaldo Carvalho de Melo
2015-08-08 16:45 ` Jiri Olsa
2015-08-08 17:35 ` Arnaldo Carvalho de Melo [this message]
2015-08-10 13:46 ` Arnaldo Carvalho de Melo
2015-08-10 12:56 ` Liang, Kan
2015-08-10 15:39 ` Arnaldo Carvalho de Melo
2015-08-10 18:57 ` Liang, Kan
2015-08-10 19:39 ` Arnaldo Carvalho de Melo
2015-08-08 17:12 ` [PATCH] perf tools: Unset perf_event_attr::freq when period term is set Jiri Olsa
2015-08-12 12:29 ` [tip:perf/core] perf tools: Unset perf_event_attr:: freq " tip-bot for Jiri Olsa
2015-08-06 19:44 ` [PATCH RFC V9 3/3] perf,tests: Add tests to callgraph and time parse kan.liang
2015-08-07 10:54 ` Jiri Olsa
2015-08-07 10:51 ` [PATCH] perf tools: Move perf_counts struct and functions into separate object Jiri Olsa
2015-08-07 13:14 ` Arnaldo Carvalho de Melo
2015-08-12 12:28 ` [tip:perf/core] perf stat: " tip-bot for Jiri Olsa
2015-08-12 12:29 ` [tip:perf/core] perf callchain: Move option parsing code to util.c tip-bot for Kan Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150808173555.GC16520@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.