From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@poochiereds.net>
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 04/18] nfsd: add a new struct file caching facility to nfsd
Date: Sun, 9 Aug 2015 00:17:02 -0700 [thread overview]
Message-ID: <20150809071702.GD9772@infradead.org> (raw)
In-Reply-To: <1438809216-4846-5-git-send-email-jeff.layton@primarydata.com>
On Wed, Aug 05, 2015 at 05:13:22PM -0400, Jeff Layton wrote:
> Currently, NFSv2/3 reads and writes have to open a file, do the read or
> write and then close it again for each RPC. This is highly inefficient,
> especially when the underlying filesystem has a relatively slow open
> routine.
.. as do many NFSv4 reads and writes as they often get special stateids
passed from the client. Seems a little odd that we take more care
of this for the legacy protocols than the current one.
I think I'd rather see a nfs4_file cache and turn v2/3 into something
like the special stateid case. Did you consider that?
next prev parent reply other threads:[~2015-08-09 7:17 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 13:52 [PATCH 0/9] nfsd: open file caching for v2/3 Jeff Layton
2015-07-30 13:52 ` [PATCH] nfsd: do nfs4_check_fh in nfs4_check_file instead of nfs4_check_olstateid Jeff Layton
2015-07-30 13:53 ` Jeff Layton
2015-07-30 15:51 ` Christoph Hellwig
2015-07-30 16:20 ` Jeff Layton
2015-07-30 16:34 ` Christoph Hellwig
2015-07-30 13:52 ` [PATCH 1/9] nfsd: include linux/nfs4.h in export.h Jeff Layton
2015-07-30 13:52 ` [PATCH 2/9] nfsd: move some file caching helpers to a common header Jeff Layton
2015-07-30 13:52 ` [PATCH 3/9] nfsd: convert laundry_wq to something less nfsd4 specific Jeff Layton
2015-07-31 21:32 ` J. Bruce Fields
2015-07-31 22:27 ` Jeff Layton
2015-07-30 13:52 ` [PATCH 4/9] nfsd: add a new struct file caching facility to nfsd Jeff Layton
2015-07-30 13:52 ` [PATCH 5/9] nfsd: hook up nfsd_write to the new nfsd_file cache Jeff Layton
2015-07-30 13:52 ` [PATCH 6/9] nfsd: hook up nfsd_read to the " Jeff Layton
2015-07-30 13:52 ` [PATCH 7/9] sunrpc: add a new cache_detail operation for when a cache is flushed Jeff Layton
2015-07-30 13:52 ` [PATCH 8/9] nfsd: add a ->flush routine to svc_export_cache Jeff Layton
2015-07-30 13:52 ` [PATCH 9/9] nfsd: allow the file cache expire time to be tunable Jeff Layton
2015-08-05 21:13 ` [PATCH v2 00/18] nfsd: open file caching for v2/3 Jeff Layton
2015-08-05 21:13 ` [PATCH v2 01/18] nfsd: include linux/nfs4.h in export.h Jeff Layton
2015-08-09 7:12 ` Christoph Hellwig
2015-08-05 21:13 ` [PATCH v2 02/18] nfsd: move some file caching helpers to a common header Jeff Layton
2015-08-07 15:25 ` Kinglong Mee
2015-08-07 17:07 ` Jeff Layton
2015-08-09 7:12 ` Christoph Hellwig
2015-08-05 21:13 ` [PATCH v2 03/18] nfsd: convert laundry_wq to something less nfsd4 specific Jeff Layton
2015-08-07 15:26 ` Kinglong Mee
2015-08-07 17:12 ` Jeff Layton
2015-08-09 7:14 ` Christoph Hellwig
2015-08-09 11:11 ` Jeff Layton
2015-08-10 8:26 ` Christoph Hellwig
2015-08-10 11:23 ` Jeff Layton
2015-08-10 12:10 ` Christoph Hellwig
2015-08-10 12:14 ` Jeff Layton
2015-08-10 14:33 ` J. Bruce Fields
2015-08-05 21:13 ` [PATCH v2 04/18] nfsd: add a new struct file caching facility to nfsd Jeff Layton
2015-08-07 15:28 ` Kinglong Mee
2015-08-07 17:18 ` Jeff Layton
2015-08-08 0:14 ` Kinglong Mee
2015-08-08 10:36 ` Jeff Layton
2015-08-10 11:36 ` Kinglong Mee
2015-08-09 7:17 ` Christoph Hellwig [this message]
2015-08-09 11:19 ` Jeff Layton
2015-08-10 8:28 ` Christoph Hellwig
2015-08-10 11:31 ` Jeff Layton
2015-08-05 21:13 ` [PATCH v2 05/18] nfsd: hook up nfsd_write to the new nfsd_file cache Jeff Layton
2015-08-05 21:13 ` [PATCH v2 06/18] nfsd: hook up nfsd_read to the " Jeff Layton
2015-08-07 15:29 ` Kinglong Mee
2015-08-07 17:26 ` Jeff Layton
2015-08-08 0:19 ` Kinglong Mee
2015-08-05 21:13 ` [PATCH v2 07/18] sunrpc: add a new cache_detail operation for when a cache is flushed Jeff Layton
2015-08-05 21:13 ` [PATCH v2 08/18] nfsd: add a ->flush routine to svc_export_cache Jeff Layton
2015-08-05 21:13 ` [PATCH v2 09/18] nfsd: allow the file cache expire time to be tunable Jeff Layton
2015-08-05 21:13 ` [PATCH v2 10/18] nfsd: handle NFSD_MAY_NOT_BREAK_LEASE in open file cache Jeff Layton
2015-08-05 21:13 ` [PATCH v2 11/18] nfsd: hook nfsd_commit up to the nfsd_file cache Jeff Layton
2015-08-05 21:13 ` [PATCH v2 12/18] nfsd: move include of state.h from trace.c to trace.h Jeff Layton
2015-08-09 7:18 ` Christoph Hellwig
2015-08-05 21:13 ` [PATCH v2 13/18] nfsd: add new tracepoints for nfsd_file cache Jeff Layton
2015-08-05 21:13 ` [PATCH v2 14/18] nfsd: have _fh_update take a knfsd_fh instead of a svc_fh Jeff Layton
2015-08-09 7:21 ` Christoph Hellwig
2015-08-05 21:13 ` [PATCH v2 15/18] nfsd: have set_version_and_fsid_type take a knfsd_fh instead of svc_fh Jeff Layton
2015-08-09 7:21 ` Christoph Hellwig
2015-08-05 21:13 ` [PATCH v2 16/18] nfsd: add a fh_compose_shallow Jeff Layton
2015-08-07 15:33 ` Kinglong Mee
2015-08-07 17:56 ` Jeff Layton
2015-08-07 18:24 ` Jeff Layton
2015-08-08 0:27 ` Kinglong Mee
2015-08-08 10:38 ` Jeff Layton
2015-08-05 21:13 ` [PATCH v2 17/18] nfsd: close cached files prior to a REMOVE or RENAME that would replace target Jeff Layton
2015-08-05 21:13 ` [PATCH v2 18/18] nfsd: call flush_delayed_fput from nfsd_file_close_fh Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150809071702.GD9772@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.