From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 01/11] xfs: disentagle EFI release from the extent count
Date: Sun, 9 Aug 2015 00:36:41 -0700 [thread overview]
Message-ID: <20150809073641.GA3163@infradead.org> (raw)
In-Reply-To: <1438883072-28706-2-git-send-email-bfoster@redhat.com>
On Thu, Aug 06, 2015 at 01:44:22PM -0400, Brian Foster wrote:
- __xfs_efi_release(efip);
+ xfs_efi_release(efip);
Can you explain in the changelog why this is safe?
> -xfs_efi_release(xfs_efi_log_item_t *efip,
> - uint nextents)
> +xfs_efi_release(struct xfs_efi_log_item *efip)
Can you use normal XFS function formatting here? e.g.
xfs_efi_release(
struct xfs_efi_log_item *efip)
As a follow on we should be able to remove atomic_inc_return and
replace it with a local iterator in xfs_bmap_finish().
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-08-09 7:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 17:44 [PATCH 00/11] xfs: miscellaneous logging, recovery, umount fixes Brian Foster
2015-08-06 17:44 ` [PATCH 01/11] xfs: disentagle EFI release from the extent count Brian Foster
2015-08-09 7:36 ` Christoph Hellwig [this message]
2015-08-10 12:37 ` Brian Foster
2015-08-12 7:15 ` Christoph Hellwig
2015-08-12 12:47 ` Brian Foster
2015-08-06 17:44 ` [PATCH 02/11] xfs: return committed status from xfs_trans_roll() Brian Foster
2015-08-09 7:37 ` Christoph Hellwig
2015-08-06 17:44 ` [PATCH 03/11] xfs: fix efi/efd error handling to avoid fs shutdown hangs Brian Foster
2015-08-07 0:41 ` Dave Chinner
2015-08-07 12:09 ` Brian Foster
2015-08-07 22:45 ` Dave Chinner
2015-08-09 7:46 ` Christoph Hellwig
2015-08-06 17:44 ` [PATCH 04/11] xfs: ensure EFD trans aborts on log recovery extent free failure Brian Foster
2015-08-09 7:53 ` Christoph Hellwig
2015-08-10 12:38 ` Brian Foster
2015-08-10 13:39 ` Brian Foster
2015-08-06 17:44 ` [PATCH 05/11] xfs: use EFI refcount consistently in log recovery Brian Foster
2015-08-07 1:51 ` Dave Chinner
2015-08-07 12:09 ` Brian Foster
2015-08-09 7:56 ` Christoph Hellwig
2015-08-10 12:37 ` Brian Foster
2015-08-06 17:44 ` [PATCH 06/11] xfs: don't leave EFIs on AIL on mount failure Brian Foster
2015-08-07 2:23 ` Dave Chinner
2015-08-07 12:10 ` Brian Foster
2015-08-09 8:01 ` Christoph Hellwig
2015-08-10 12:38 ` Brian Foster
2015-08-06 17:44 ` [PATCH 07/11] xfs: icreate log item recovery and cancellation tracepoints Brian Foster
2015-08-09 8:02 ` Christoph Hellwig
2015-08-06 17:44 ` [PATCH 08/11] xfs: fix broken icreate log item cancellation Brian Foster
2015-08-06 17:44 ` [PATCH 09/11] xfs: checksum log record ext headers based on record size Brian Foster
2015-08-06 17:44 ` [PATCH 10/11] xfs: clean up root inode properly on mount failure Brian Foster
2015-08-09 8:03 ` Christoph Hellwig
2015-08-06 17:44 ` [PATCH 11/11] xfs: fix btree cursor error cleanups Brian Foster
2015-08-09 8:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150809073641.GA3163@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.