From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain/external: better check for gcc-5
Date: Sun, 9 Aug 2015 17:17:01 +0200 [thread overview]
Message-ID: <20150809171701.331c2ed5@free-electrons.com> (raw)
In-Reply-To: <1439118702-5376-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Sun, 9 Aug 2015 13:11:42 +0200, Yann E. MORIN wrote:
> gcc will always report a three-digit version sting, like 4.9.3 or 5.1.0.
>
> For gcc before 5, we want to check the first two digits, while starting
> with gcc 5, we are only concerned about the first digit.
>
> So, change our matching code to test for the leading part of the version
> string, up to the first dot after as-many version digit we're interested
> in.
>
> Note: we're adding the dot in the .mk code rather than in the Kconfig
> symbol, because it seemed cleaner to do so.
>
> Reported-by: J?rg Krause <joerg.krause@embedded.rocks>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> toolchain/helpers.mk | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-08-09 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-09 11:11 [Buildroot] [PATCH] toolchain/external: better check for gcc-5 Yann E. MORIN
2015-08-09 15:17 ` Thomas Petazzoni [this message]
2015-08-09 18:13 ` Jörg Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150809171701.331c2ed5@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.