All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@iguana.be>,
	kernel@pengutronix.de, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v1 3/5] watchdog: mpc8xxx: make use of of_device_get_match_data
Date: Mon, 10 Aug 2015 09:24:28 +0200	[thread overview]
Message-ID: <20150810072428.GP9999@pengutronix.de> (raw)
In-Reply-To: <55C4C733.7000802@roeck-us.net>

Hello Guenter,

On Fri, Aug 07, 2015 at 07:56:51AM -0700, Guenter Roeck wrote:
> >  	enabled = in_be32(&wd_base->swcrr) & SWCRR_SWEN;
> >  	if (!enabled && wdt_type->hw_enabled) {
> >  		pr_info("could not be enabled in software\n");
> >-		ret = -ENOSYS;
> >-		goto err_unmap;
> >+		return -ENOSYS;
> >  	}
> 
> checkpatch says:
> 
> WARNING: ENOSYS means 'invalid syscall nr' and nothing else
> #65: FILE: drivers/watchdog/mpc8xxx_wdt.c:166:
> +		return -ENOSYS;
> 
> Maybe just use -ENODEV.
That would be a separate patch tough because I'm just changing the code
flow and ENOSYS was there already before.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2015-08-10  7:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07 10:07 [PATCH v1 0/5] watchdog: mpc8xxx: several cleanups Uwe Kleine-König
2015-08-07 10:07 ` [PATCH v1 1/5] watchdog: mpc8xxx: remove dead code Uwe Kleine-König
2015-08-07 14:52   ` Guenter Roeck
2015-08-07 10:07 ` [PATCH v1 2/5] watchdog: mpc8xxx: simplify registration Uwe Kleine-König
2015-08-07 14:55   ` Guenter Roeck
2015-08-07 10:07 ` [PATCH v1 3/5] watchdog: mpc8xxx: make use of of_device_get_match_data Uwe Kleine-König
2015-08-07 14:56   ` Guenter Roeck
2015-08-10  7:24     ` Uwe Kleine-König [this message]
2015-08-10 17:33       ` Guenter Roeck
2015-08-10  7:25   ` Uwe Kleine-König
2015-08-10 17:33     ` Guenter Roeck
2015-08-07 10:07 ` [PATCH v1 4/5] watchdog: mpc8xxx: use dynamic memory for device specific data Uwe Kleine-König
2015-08-07 14:59   ` Guenter Roeck
2015-08-07 10:07 ` [PATCH v1 5/5] watchdog: mpc8xxx: allow to compile for MPC512x Uwe Kleine-König
2015-08-07 15:00   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150810072428.GP9999@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.