All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio properties.
Date: Mon, 10 Aug 2015 14:38:01 +0200	[thread overview]
Message-ID: <20150810123800.GB1262@ulmo.nvidia.com> (raw)
In-Reply-To: <1439207974-30902-1-git-send-email-srinivas.kandagatla@linaro.org>


[-- Attachment #1.1: Type: text/plain, Size: 968 bytes --]

On Mon, Aug 10, 2015 at 12:59:34PM +0100, Srinivas Kandagatla wrote:
> This patch modifies the driver to support standard gpio properties along
> with deprecated properties. This will help us upstream and cleanup the
> non-standard properties over the time.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  drivers/gpu/drm/msm/hdmi/hdmi.c | 35 +++++++++++++++++++++++++----------
>  1 file changed, 25 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
> index 8145362..e918889 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
> @@ -339,19 +339,34 @@ static const struct of_device_id dt_match[] = {
>  };
>  
>  #ifdef CONFIG_OF
> +/* This code will be removed once we move to gpiod based calls */

Why don't you do this now instead of duplicating what is essentially
already implemented in gpiolib?

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: dri-devel@lists.freedesktop.org, robdclark@gmail.com,
	David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio properties.
Date: Mon, 10 Aug 2015 14:38:01 +0200	[thread overview]
Message-ID: <20150810123800.GB1262@ulmo.nvidia.com> (raw)
In-Reply-To: <1439207974-30902-1-git-send-email-srinivas.kandagatla@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 968 bytes --]

On Mon, Aug 10, 2015 at 12:59:34PM +0100, Srinivas Kandagatla wrote:
> This patch modifies the driver to support standard gpio properties along
> with deprecated properties. This will help us upstream and cleanup the
> non-standard properties over the time.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  drivers/gpu/drm/msm/hdmi/hdmi.c | 35 +++++++++++++++++++++++++----------
>  1 file changed, 25 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
> index 8145362..e918889 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
> @@ -339,19 +339,34 @@ static const struct of_device_id dt_match[] = {
>  };
>  
>  #ifdef CONFIG_OF
> +/* This code will be removed once we move to gpiod based calls */

Why don't you do this now instead of duplicating what is essentially
already implemented in gpiolib?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-08-10 12:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 11:58 [PATCH RFC 0/5] drm/msm/hdmi: DT bindings cleanup Srinivas Kandagatla
2015-08-10 11:59 ` [PATCH RFC 1/5] drm/msm/hdmi: deprecate non standard gpio properties Srinivas Kandagatla
2015-08-10 12:45   ` Thierry Reding
2015-08-10 12:45     ` Thierry Reding
2015-08-10 22:07     ` Rob Herring
2015-08-10 22:27       ` Bjorn Andersson
2015-08-11  0:25         ` Rob Clark
2015-08-11  0:25           ` Rob Clark
2015-08-10 11:59 ` [PATCH RFC 2/5] drm/msm/hdmi: make use of " Srinivas Kandagatla
2015-08-10 12:38   ` Thierry Reding [this message]
2015-08-10 12:38     ` Thierry Reding
2015-08-10 13:15     ` Srinivas Kandagatla
2015-08-10 13:26       ` Thierry Reding
2015-08-10 13:26         ` Thierry Reding
2015-08-10 13:49         ` Srinivas Kandagatla
2015-08-10 11:59 ` [PATCH RFC 3/5] drm/msm/hdmi: update bindings to include clock-names Srinivas Kandagatla
2015-08-10 11:59 ` [PATCH RFC 4/5] drm/msm/hdmi: deprecate non standard clock-names Srinivas Kandagatla
2015-08-10 12:49   ` Thierry Reding
2015-08-10 12:49     ` Thierry Reding
2015-08-10 13:18     ` Srinivas Kandagatla
2015-08-10 13:33       ` Thierry Reding
2015-08-10 13:42         ` Srinivas Kandagatla
2015-08-10 11:59 ` [PATCH RFC 5/5] drm/msm/hdmi: remove _clk suffix from clock names Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150810123800.GB1262@ulmo.nvidia.com \
    --to=thierry.reding@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.