Re: [PATCH v4 2/6] mfd: da9150: Update DT bindings for Fuel-Gauge support

[Lee Jones <lee.jones@linaro.org>]

On Tue, 04 Aug 2015, Adam Thomson wrote:

> Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> ---
> 
> Changes in v4:
>  - Update compatible string of fuel-gauge to "da9150-fuel-gauge".
>  - Node name tidy up, relating to maintainer comments on fuel-gauge DT
>    binding doc.
>  - Removed Ack to patch from Lee Jones, as this has now been modified slightly
>    and didn't want to make assumptions of approval.

Seems okay:

Acked-by: Lee Jones <lee.jones@linaro.org>

> Changes in v3:
>  - Removal of unwanted new-line.
>  - Flesh out example bindings usage.
> 
> Changes in v2:
>  - N/A
> 
>  Documentation/devicetree/bindings/mfd/da9150.txt | 27 ++++++++++++++++++++----
>  1 file changed, 23 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/da9150.txt b/Documentation/devicetree/bindings/mfd/da9150.txt
> index d0588ea..970801d 100644
> --- a/Documentation/devicetree/bindings/mfd/da9150.txt
> +++ b/Documentation/devicetree/bindings/mfd/da9150.txt
> @@ -6,6 +6,7 @@ Device			 Description
>  ------			 -----------
>  da9150-gpadc		: General Purpose ADC
>  da9150-charger		: Battery Charger
> +da9150-fg		: Battery Fuel-Gauge
> 
>  ======
> 
> @@ -22,7 +23,7 @@ Required properties:
>  Sub-devices:
>  - da9150-gpadc: See Documentation/devicetree/bindings/iio/adc/da9150-gpadc.txt
>  - da9150-charger: See Documentation/devicetree/bindings/power/da9150-charger.txt
> -
> +- da9150-fg: See Documentation/devicetree/bindings/power/da9150-fg.txt
> 
>  Example:
> 
> @@ -34,10 +35,28 @@ Example:
>  		interrupt-controller;
> 
>  		gpadc: da9150-gpadc {
> -			...
> +			compatible = "dlg,da9150-gpadc";
> +			#io-channel-cells = <1>;
> +		};
> +
> +		charger {
> +			compatible = "dlg,da9150-charger";
> +
> +			io-channels = <&gpadc 0>,
> +				      <&gpadc 2>,
> +				      <&gpadc 8>,
> +				      <&gpadc 5>;
> +			io-channel-names = "CHAN_IBUS",
> +					   "CHAN_VBUS",
> +					   "CHAN_TJUNC",
> +					   "CHAN_VBAT";
>  		};
> 
> -		da9150-charger {
> -			...
> +		fuel-gauge {
> +			compatible = "dlg,da9150-fuel-gauge";
> +
> +			dlg,update-interval = <10000>;
> +			dlg,warn-soc-level = /bits/ 8 <15>;
> +			dlg,crit-soc-level = /bits/ 8 <5>
>  		};
>  	};

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog