All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Fabio Estevam <fabio.estevam@freescale.com>
Cc: festevam@gmail.com, rtc-linux@googlegroups.com
Subject: [rtc-linux] Re: [PATCH 2/2] rtc: rtc-ds1374: Remove unused variable
Date: Mon, 10 Aug 2015 16:00:42 +0200	[thread overview]
Message-ID: <20150810140042.GF3411@piout.net> (raw)
In-Reply-To: <1439210865-8611-2-git-send-email-fabio.estevam@freescale.com>

Greg,

Can you take this one or squash it in your misc_deregister patch?

Original is at: http://patchwork.ozlabs.org/patch/505614/

On 10/08/2015 at 09:47:45 -0300, Fabio Estevam wrote :
> Remove unused variable 'res' and fix the following build warning:
> 
> drivers/rtc/rtc-ds1374.c:667:6: warning: unused variable 'res' [-Wunused-variable]
> 
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/rtc/rtc-ds1374.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c
> index 7067232..3b3049c 100644
> --- a/drivers/rtc/rtc-ds1374.c
> +++ b/drivers/rtc/rtc-ds1374.c
> @@ -664,8 +664,6 @@ static int ds1374_remove(struct i2c_client *client)
>  {
>  	struct ds1374 *ds1374 = i2c_get_clientdata(client);
>  #ifdef CONFIG_RTC_DRV_DS1374_WDT
> -	int res;
> -
>  	misc_deregister(&ds1374_miscdev);
>  	ds1374_miscdev.parent = NULL;
>  	unregister_reboot_notifier(&ds1374_wdt_notifier);
> -- 
> 1.9.1
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

  reply	other threads:[~2015-08-10 14:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 12:47 [rtc-linux] [PATCH 1/2] rtc: rtc-cmos: Remove unused variable Fabio Estevam
2015-08-10 12:47 ` [rtc-linux] [PATCH 2/2] rtc: rtc-ds1374: " Fabio Estevam
2015-08-10 14:00   ` Alexandre Belloni [this message]
2015-09-05 11:24   ` [rtc-linux] " Alexandre Belloni
2015-08-10 14:01 ` [rtc-linux] Re: [PATCH 1/2] rtc: rtc-cmos: " Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150810140042.GF3411@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.