From: Dan Carpenter <dan.carpenter@oracle.com>
To: viresh.kumar@linaro.org
Cc: linux-pm@vger.kernel.org
Subject: re: PM / OPP: Add clock-latency-ns support
Date: Mon, 10 Aug 2015 19:38:04 +0300 [thread overview]
Message-ID: <20150810163804.GA10496@mwanda> (raw)
Hello Viresh Kumar,
The patch 3ca9bb33c627: "PM / OPP: Add clock-latency-ns support" from
Jul 29, 2015, leads to the following static checker warning:
drivers/base/power/opp.c:949 _opp_add_static_v2()
warn: passing casted pointer '&new_opp->clock_latency_ns' to 'of_property_read_u32()' 64 vs 32.
drivers/base/power/opp.c
946 new_opp->np = np;
947 new_opp->dynamic = false;
948 new_opp->available = true;
949 of_property_read_u32(np, "clock-latency-ns",
950 (u32 *)&new_opp->clock_latency_ns);
^^^^^^^^^^^^^^^^^^^^^^^^^^
This code will break on 64 bit, big endian machines. I doin't know if
that is an issue for this driver. I saw this was in the power/
directory and I spent a minute googling to see if PowerPC machines are
big endian... :P
951
952 ret = opp_get_microvolt(new_opp, dev);
953 if (ret)
954 goto free_opp;
955
Also:
drivers/base/power/opp.c:956 _opp_add_static_v2()
warn: passing casted pointer '&new_opp->u_amp' to 'of_property_read_u32()' 64 vs 32.
regards,
dan carpenter
next reply other threads:[~2015-08-10 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 16:38 Dan Carpenter [this message]
2015-08-11 8:12 ` PM / OPP: Add clock-latency-ns support Viresh Kumar
2015-08-11 13:53 ` Dan Carpenter
2015-08-11 18:54 ` Stephen Boyd
2015-08-12 6:57 ` Viresh Kumar
2015-08-12 7:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150810163804.GA10496@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-pm@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.