From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg KH) Date: Mon, 10 Aug 2015 11:54:00 -0700 Subject: [PATCH 2/3] kobject: export kset_find_obj() to be used from modules In-Reply-To: <20150810184310.GM31816@HEDWIG.INI.CMU.EDU> References: <5c2bafb073e1386e39c4f73a83e7d835547b6b1f.1439220623.git.somlo@cmu.edu> <20150810183304.GC18817@kroah.com> <20150810184310.GM31816@HEDWIG.INI.CMU.EDU> Message-ID: <20150810185400.GC19646@kroah.com> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org On Mon, Aug 10, 2015 at 02:43:10PM -0400, Gabriel L. Somlo wrote: > On Mon, Aug 10, 2015 at 11:33:04AM -0700, Greg KH wrote: > > On Mon, Aug 10, 2015 at 12:31:19PM -0400, Gabriel L. Somlo wrote: > > > From: "Gabriel Somlo" > > > > > > Signed-off-by: Gabriel Somlo > > > --- > > > lib/kobject.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/kobject.c b/lib/kobject.c > > > index 3e3a5c3..f9754a0 100644 > > > --- a/lib/kobject.c > > > +++ b/lib/kobject.c > > > @@ -1058,3 +1058,4 @@ EXPORT_SYMBOL(kobject_del); > > > > > > EXPORT_SYMBOL(kset_register); > > > EXPORT_SYMBOL(kset_unregister); > > > +EXPORT_SYMBOL(kset_find_obj); > > > > checkpatch doesn't like this for obvious reasons :) > > When I run checkpatch on this one, it comes back fine. Could you > please elaborate ? > > [staging]$ scripts/checkpatch.pl > 0002-kobject-export-kset_find_obj-to-be-used-from-modules.patch > total: 0 errors, 0 warnings, 4 lines checked > > 0002-kobject-export-kset_find_obj-to-be-used-from-modules.patch has no > obvious style problems and is ready for submission. EXPORT_SYMBOL() should be below the function definition itself, not at the bottom of the file. Odd that checkpatch doesn't catch this when done in this manner, it will if you run it on the whole file after your patch is applied (along with the existing problems.) But this is a minor issue, see my other review first... greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 2/3] kobject: export kset_find_obj() to be used from modules Date: Mon, 10 Aug 2015 11:54:00 -0700 Message-ID: <20150810185400.GC19646@kroah.com> References: <5c2bafb073e1386e39c4f73a83e7d835547b6b1f.1439220623.git.somlo@cmu.edu> <20150810183304.GC18817@kroah.com> <20150810184310.GM31816@HEDWIG.INI.CMU.EDU> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150810184310.GM31816-h65ZQ0r4j6KKUezXOiBB2eW1CriLhL8O@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Gabriel L. Somlo" Cc: ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org, lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, jordan.l.justen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, gleb-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org, pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, eblake-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, rjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kernelnewbies-7JyXY6prKcjpASu1u0TL5ti2O/JbrIOy@public.gmane.org List-Id: linux-api@vger.kernel.org On Mon, Aug 10, 2015 at 02:43:10PM -0400, Gabriel L. Somlo wrote: > On Mon, Aug 10, 2015 at 11:33:04AM -0700, Greg KH wrote: > > On Mon, Aug 10, 2015 at 12:31:19PM -0400, Gabriel L. Somlo wrote: > > > From: "Gabriel Somlo" > > > > > > Signed-off-by: Gabriel Somlo > > > --- > > > lib/kobject.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/kobject.c b/lib/kobject.c > > > index 3e3a5c3..f9754a0 100644 > > > --- a/lib/kobject.c > > > +++ b/lib/kobject.c > > > @@ -1058,3 +1058,4 @@ EXPORT_SYMBOL(kobject_del); > > > > > > EXPORT_SYMBOL(kset_register); > > > EXPORT_SYMBOL(kset_unregister); > > > +EXPORT_SYMBOL(kset_find_obj); > > > > checkpatch doesn't like this for obvious reasons :) > > When I run checkpatch on this one, it comes back fine. Could you > please elaborate ? > > [staging]$ scripts/checkpatch.pl > 0002-kobject-export-kset_find_obj-to-be-used-from-modules.patch > total: 0 errors, 0 warnings, 4 lines checked > > 0002-kobject-export-kset_find_obj-to-be-used-from-modules.patch has no > obvious style problems and is ready for submission. EXPORT_SYMBOL() should be below the function definition itself, not at the bottom of the file. Odd that checkpatch doesn't catch this when done in this manner, it will if you run it on the whole file after your patch is applied (along with the existing problems.) But this is a minor issue, see my other review first... greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932739AbbHJSyF (ORCPT ); Mon, 10 Aug 2015 14:54:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45772 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932364AbbHJSyB (ORCPT ); Mon, 10 Aug 2015 14:54:01 -0400 Date: Mon, 10 Aug 2015 11:54:00 -0700 From: Greg KH To: "Gabriel L. Somlo" Cc: ralf@linux-mips.org, zajec5@gmail.com, paul@pwsan.com, galak@codeaurora.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, matt.fleming@intel.com, x86@kernel.org, linux-efi@vger.kernel.org, qemu-devel@nongnu.org, lersek@redhat.com, jordan.l.justen@intel.com, gleb@cloudius-systems.com, pbonzini@redhat.com, kraxel@redhat.com, eblake@redhat.com, rjones@redhat.com, kernelnewbies@kernelnewbies.org Subject: Re: [PATCH 2/3] kobject: export kset_find_obj() to be used from modules Message-ID: <20150810185400.GC19646@kroah.com> References: <5c2bafb073e1386e39c4f73a83e7d835547b6b1f.1439220623.git.somlo@cmu.edu> <20150810183304.GC18817@kroah.com> <20150810184310.GM31816@HEDWIG.INI.CMU.EDU> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150810184310.GM31816@HEDWIG.INI.CMU.EDU> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 10, 2015 at 02:43:10PM -0400, Gabriel L. Somlo wrote: > On Mon, Aug 10, 2015 at 11:33:04AM -0700, Greg KH wrote: > > On Mon, Aug 10, 2015 at 12:31:19PM -0400, Gabriel L. Somlo wrote: > > > From: "Gabriel Somlo" > > > > > > Signed-off-by: Gabriel Somlo > > > --- > > > lib/kobject.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/kobject.c b/lib/kobject.c > > > index 3e3a5c3..f9754a0 100644 > > > --- a/lib/kobject.c > > > +++ b/lib/kobject.c > > > @@ -1058,3 +1058,4 @@ EXPORT_SYMBOL(kobject_del); > > > > > > EXPORT_SYMBOL(kset_register); > > > EXPORT_SYMBOL(kset_unregister); > > > +EXPORT_SYMBOL(kset_find_obj); > > > > checkpatch doesn't like this for obvious reasons :) > > When I run checkpatch on this one, it comes back fine. Could you > please elaborate ? > > [staging]$ scripts/checkpatch.pl > 0002-kobject-export-kset_find_obj-to-be-used-from-modules.patch > total: 0 errors, 0 warnings, 4 lines checked > > 0002-kobject-export-kset_find_obj-to-be-used-from-modules.patch has no > obvious style problems and is ready for submission. EXPORT_SYMBOL() should be below the function definition itself, not at the bottom of the file. Odd that checkpatch doesn't catch this when done in this manner, it will if you run it on the whole file after your patch is applied (along with the existing problems.) But this is a minor issue, see my other review first... greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOsCz-0006Xn-E8 for qemu-devel@nongnu.org; Mon, 10 Aug 2015 14:54:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZOsCw-00070c-4A for qemu-devel@nongnu.org; Mon, 10 Aug 2015 14:54:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOsCv-00070Q-U7 for qemu-devel@nongnu.org; Mon, 10 Aug 2015 14:54:02 -0400 Date: Mon, 10 Aug 2015 11:54:00 -0700 From: Greg KH Message-ID: <20150810185400.GC19646@kroah.com> References: <5c2bafb073e1386e39c4f73a83e7d835547b6b1f.1439220623.git.somlo@cmu.edu> <20150810183304.GC18817@kroah.com> <20150810184310.GM31816@HEDWIG.INI.CMU.EDU> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150810184310.GM31816@HEDWIG.INI.CMU.EDU> Subject: Re: [Qemu-devel] [PATCH 2/3] kobject: export kset_find_obj() to be used from modules List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: x86@kernel.org, paul@pwsan.com, matt.fleming@intel.com, gleb@cloudius-systems.com, jordan.l.justen@intel.com, rjones@redhat.com, linux-api@vger.kernel.org, zajec5@gmail.com, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, linux-efi@vger.kernel.org, kernelnewbies@kernelnewbies.org, kraxel@redhat.com, galak@codeaurora.org, pbonzini@redhat.com, lersek@redhat.com On Mon, Aug 10, 2015 at 02:43:10PM -0400, Gabriel L. Somlo wrote: > On Mon, Aug 10, 2015 at 11:33:04AM -0700, Greg KH wrote: > > On Mon, Aug 10, 2015 at 12:31:19PM -0400, Gabriel L. Somlo wrote: > > > From: "Gabriel Somlo" > > > > > > Signed-off-by: Gabriel Somlo > > > --- > > > lib/kobject.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/kobject.c b/lib/kobject.c > > > index 3e3a5c3..f9754a0 100644 > > > --- a/lib/kobject.c > > > +++ b/lib/kobject.c > > > @@ -1058,3 +1058,4 @@ EXPORT_SYMBOL(kobject_del); > > > > > > EXPORT_SYMBOL(kset_register); > > > EXPORT_SYMBOL(kset_unregister); > > > +EXPORT_SYMBOL(kset_find_obj); > > > > checkpatch doesn't like this for obvious reasons :) > > When I run checkpatch on this one, it comes back fine. Could you > please elaborate ? > > [staging]$ scripts/checkpatch.pl > 0002-kobject-export-kset_find_obj-to-be-used-from-modules.patch > total: 0 errors, 0 warnings, 4 lines checked > > 0002-kobject-export-kset_find_obj-to-be-used-from-modules.patch has no > obvious style problems and is ready for submission. EXPORT_SYMBOL() should be below the function definition itself, not at the bottom of the file. Odd that checkpatch doesn't catch this when done in this manner, it will if you run it on the whole file after your patch is applied (along with the existing problems.) But this is a minor issue, see my other review first... greg k-h