From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOxsg-0003Ul-7I for qemu-devel@nongnu.org; Mon, 10 Aug 2015 20:57:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZOxsd-0004ad-1g for qemu-devel@nongnu.org; Mon, 10 Aug 2015 20:57:30 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:60267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOxsc-0004Yx-D8 for qemu-devel@nongnu.org; Mon, 10 Aug 2015 20:57:26 -0400 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 11 Aug 2015 06:27:21 +0530 Date: Tue, 11 Aug 2015 10:57:14 +1000 From: Gavin Shan Message-ID: <20150811005713.GA21087@gwshan> References: <1438918413-8247-1-git-send-email-gwshan@linux.vnet.ibm.com> <1438918413-8247-3-git-send-email-gwshan@linux.vnet.ibm.com> <20150810122456.GC18650@voom.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150810122456.GC18650@voom.redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 2/3] sPAPR: Support RTAS call ibm, {open, close}-errinjct Reply-To: Gavin Shan List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aik@ozlabs.ru, qemu-ppc@nongnu.org, Gavin Shan , qemu-devel@nongnu.org On Mon, Aug 10, 2015 at 10:24:56PM +1000, David Gibson wrote: >On Fri, Aug 07, 2015 at 01:33:32PM +1000, Gavin Shan wrote: >> The patch supports RTAS calls "ibm,{open,close}-errinjct" to >> manupliate the token, which is passed to RTAS call "ibm,errinjct" >> to indicate the valid context for error injection. Each VM is >> permitted to have only one token at once and we simply have one >> random number for that. >> >> Signed-off-by: Gavin Shan >> --- >> hw/ppc/spapr.c | 5 ++++ >> hw/ppc/spapr_rtas.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++ >> include/hw/ppc/spapr.h | 10 +++++++- >> 3 files changed, 80 insertions(+), 1 deletion(-) >> >> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c >> index dfd808f..1ebd0b2 100644 >> --- a/hw/ppc/spapr.c >> +++ b/hw/ppc/spapr.c >> @@ -1225,6 +1225,11 @@ static const VMStateDescription vmstate_spapr = { >> VMSTATE_UINT64_TEST(rtc_offset, sPAPRMachineState, version_before_3), >> >> VMSTATE_PPC_TIMEBASE_V(tb, sPAPRMachineState, 2), >> + >> + /* Error injection token */ >> + VMSTATE_BOOL(is_errinjct_opened, sPAPRMachineState), >> + VMSTATE_UINT32(errinjct_next_token, sPAPRMachineState), > >Because you're adding fields to the vmstate you'll need to define a >new version number and make these fields only considered in the new >version. > Agree, do we have an example for me to refer to? >Technically you only need to transfer whether the token is open, and >*if* it is open the current token value. Not sure if it's worth >restricting to that though. > It would be fine to transfer the token even it's closed, I think. Thanks, Gavin