From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933610AbbHKCVc (ORCPT ); Mon, 10 Aug 2015 22:21:32 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:35130 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932670AbbHKCVb (ORCPT ); Mon, 10 Aug 2015 22:21:31 -0400 Date: Tue, 11 Aug 2015 11:05:11 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Ingo Molnar , Peter Zijlstra , LKML , David Ahern , Andi Kleen Subject: Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling with '<' and '>' key Message-ID: <20150811020511.GB2488@sejong> References: <1439108462-16391-1-git-send-email-namhyung@kernel.org> <20150809093024.GA17069@krava.brq.redhat.com> <20150809103542.GA3415@danjae.kornet> <20150809112139.GD17069@krava.brq.redhat.com> <20150810155004.GB2521@kernel.org> <20150810224603.GC27431@krava.redhat.com> <20150810225822.GH2521@kernel.org> <20150810230256.GA27382@krava.redhat.com> <20150810231445.GI2521@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150810231445.GI2521@kernel.org> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 10, 2015 at 08:14:45PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Aug 11, 2015 at 01:02:56AM +0200, Jiri Olsa escreveu: > > On Mon, Aug 10, 2015 at 07:58:22PM -0300, Arnaldo Carvalho de Melo wrote: > > > SNIP > > > > > it'd really help for perf mem output, which is quite wide.. and we probably > > > > have more wide outputs, or users with narrow terminals ;-) > > > > I'm not going against horizontal scrolling, it is needed, sure thing, > > > its surprising we are doing this only now. What I am asking is this fine > > > scrolling of one column per <- or -> keypress, but I really need to try > > > it with things like 'perf mem', I thought that when you pressed '>', in > > > this patch, it would move entire sort key columns, not just one vertical > > > column one character wide, right? > > > yep, the whole sort column seemed more usefull, > > though 1 vertical column is nice also > > We can get that by using the right and left keys while pressing shift or > alt, I think. I'd also like to do it. But it seems SLang_getkey() doesn't return the shift, alt or control key status for arrow keys. CTRL(K_LEFT) or META(K_RIGHT) didn't work for me. Anyone has an idea? Thanks, Namhyung