All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Chien Yen <chien.yen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Selvin Xavier
	<selvin.xavier-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org>,
	Devesh Sharma
	<devesh.sharma-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org>,
	Mitesh Ahuja
	<mitesh.ahuja-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org>
Subject: Re: [PATCH] IB/core: Make ib_dealloc_pd return void
Date: Mon, 10 Aug 2015 23:57:31 -0600	[thread overview]
Message-ID: <20150811055731.GD13314@obsidianresearch.com> (raw)
In-Reply-To: <55C39A0E.6020008-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>

On Thu, Aug 06, 2015 at 08:31:58PM +0300, Sagi Grimberg wrote:

> This looks generally good. Would it make sense to go the extra mile
> here and just fixup ocrdma (the only driver that seems to be able to
> fail) to WARN_ON() instead of propagating an error and make it go
> away from the core?

I've remarked to the ocrdma folks about fixing this in the past, I'm
not sure where they are on that..

There are also a few other dealloc APIs (mr, etc) that need a similar
treatment. I was planning to address the ULP side and driver side in
two steps to keep things simpler.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-08-11  5:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05 20:34 [PATCH] IB/core: Make ib_dealloc_pd return void Jason Gunthorpe
     [not found] ` <20150805203431.GB30271-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-08-05 20:50   ` Chuck Lever
     [not found]     ` <C771535C-C9AD-4AC1-81BF-2A4122D5EDAE-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-08-05 21:00       ` Anna Schumaker
     [not found]         ` <55C2795C.7060700-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>
2015-08-05 21:08           ` Chuck Lever
2015-08-06 17:56         ` Chuck Lever
2015-08-06 17:56           ` Chuck Lever
2015-08-06 17:31   ` Sagi Grimberg
     [not found]     ` <55C39A0E.6020008-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-08-11  5:57       ` Jason Gunthorpe [this message]
     [not found]         ` <20150811055731.GD13314-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-08-11  6:57           ` Sagi Grimberg
2015-08-15  1:05   ` Doug Ledford
     [not found]     ` <55CE9043.1030804-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-15  2:27       ` Jason Gunthorpe
     [not found]         ` <20150815022747.GA30693-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-08-15  3:13           ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150811055731.GD13314@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=chien.yen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=devesh.sharma-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mitesh.ahuja-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org \
    --cc=sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    --cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=selvin.xavier-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.