From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
nm@ti.com, linaro-kernel@lists.linaro.org,
linux-pm@vger.kernel.org, khilman@linaro.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Len Brown <len.brown@intel.com>,
open list <linux-kernel@vger.kernel.org>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2()
Date: Mon, 10 Aug 2015 23:09:24 -0700 [thread overview]
Message-ID: <20150811060924.GI9678@codeaurora.org> (raw)
In-Reply-To: <20150811023349.GM5766@linux>
On 08/11, Viresh Kumar wrote:
> On 10-08-15, 17:31, Stephen Boyd wrote:
> > I am not insisting anything. But another patch to get rid of the
> > goto sounds fine.
>
> The separate patch to kill goto.
>
> ---------------------8<-------------------------
>
> Message-Id: <9f9b9ea6ea3685d5f71c132e7efb18917253961f.1439260355.git.viresh.kumar@linaro.org>
> From: Viresh Kumar <viresh.kumar@linaro.org>
> Date: Tue, 11 Aug 2015 08:01:01 +0530
> Subject: [PATCH] PM / OPP: Remove unnecessary goto statements
>
> The code simply returns after jumping to the out label and doesn't free
> any resources, etc.
>
> Kill the unnecessary goto statements.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-08-11 6:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 6:31 [PATCH 0/6] PM / OPP: Add debugfs support Viresh Kumar
2015-08-10 6:31 ` [PATCH 1/6] PM / OPP: reuse of_parse_phandle() Viresh Kumar
2015-08-10 6:31 ` Viresh Kumar
2015-08-11 6:02 ` Stephen Boyd
2015-08-11 6:10 ` Viresh Kumar
2015-08-11 6:23 ` Stephen Boyd
2015-08-11 6:42 ` Viresh Kumar
2015-08-10 6:31 ` [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2() Viresh Kumar
2015-08-10 6:31 ` Viresh Kumar
2015-08-10 19:23 ` Stephen Boyd
2015-08-11 0:23 ` Viresh Kumar
2015-08-11 0:31 ` Stephen Boyd
2015-08-11 2:25 ` Viresh Kumar
2015-08-11 6:08 ` Stephen Boyd
2015-08-11 6:57 ` Viresh Kumar
2015-08-11 8:37 ` Viresh Kumar
2015-08-11 2:33 ` Viresh Kumar
2015-08-11 6:09 ` Stephen Boyd [this message]
2015-08-10 6:31 ` [PATCH 3/6] PM / OPP: Prefix exported opp routines with dev_pm_opp_ Viresh Kumar
2015-08-10 6:31 ` Viresh Kumar
2015-08-10 19:24 ` Stephen Boyd
2015-08-10 6:32 ` [PATCH 4/6] PM / OPP: Move opp core to its own directory Viresh Kumar
2015-08-10 6:32 ` Viresh Kumar
2015-08-10 19:51 ` Stephen Boyd
2015-08-11 0:25 ` Viresh Kumar
2015-08-10 6:32 ` [PATCH 5/6] PM / OPP: Move cpu specific code to opp/cpu.c Viresh Kumar
2015-08-10 6:32 ` Viresh Kumar
2015-08-11 6:09 ` Stephen Boyd
2015-08-10 6:32 ` [PATCH 6/6] PM / OPP: Add debugfs support Viresh Kumar
2015-08-10 6:32 ` Viresh Kumar
2015-08-10 19:50 ` Stephen Boyd
2015-08-11 6:35 ` Viresh Kumar
2015-08-11 6:37 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150811060924.GI9678@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@linaro.org \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.