From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934098AbbHKLPO (ORCPT <rfc822;w@1wt.eu>);
	Tue, 11 Aug 2015 07:15:14 -0400
Received: from casper.infradead.org ([85.118.1.10]:43958 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755088AbbHKLPM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 11 Aug 2015 07:15:12 -0400
Date: Tue, 11 Aug 2015 13:15:07 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH v2 3/3] sched/numa: Remove NUMA sched feature
Message-ID: <20150811111507.GN16853@twins.programming.kicks-ass.net>
References: <1439290813-6683-1-git-send-email-srikar@linux.vnet.ibm.com>
 <1439290813-6683-4-git-send-email-srikar@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1439290813-6683-4-git-send-email-srikar@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 11, 2015 at 04:30:13PM +0530, Srikar Dronamraju wrote:
> Variable sched_numa_balancing is available for both CONFIG_SCHED_DEBUG
> and !CONFIG_SCHED_DEBUG. All code paths now check for
> sched_numa_balancing. Hence remove sched_feat(NUMA).
> 
> Suggested-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
>  kernel/sched/core.c     |  6 ------
>  kernel/sched/features.h | 16 ----------------
>  2 files changed, 22 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 7cbdf44..d02570b 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -2063,12 +2063,6 @@ __read_mostly bool sched_numa_balancing;
>  void set_numabalancing_state(bool enabled)
>  {
>  	sched_numa_balancing = enabled;
> -#ifdef CONFIG_SCHED_DEBUG
> -	if (enabled)
> -		sched_feat_set("NUMA");
> -	else
> -		sched_feat_set("NO_NUMA");
> -#endif /* CONFIG_SCHED_DEBUG */
>  }

Could you at least replace sched_numa_balancing with a static_key
thingy?