All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Michael Allwright <michael.allwright@upb.de>
Cc: linux-media@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Sakari Ailus <sakari.ailus@iki.fi>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Arnd Bergmann <arnd@arndb.de>, Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH RFC] DT support for omap4-iss
Date: Tue, 11 Aug 2015 04:16:04 -0700	[thread overview]
Message-ID: <20150811111604.GD10928@atomide.com> (raw)
In-Reply-To: <CALcgO_6UXp-Xqwim8WpLXz7XWAEpejipR7JNQc0TdH0ETL4JYQ@mail.gmail.com>

* Michael Allwright <michael.allwright@upb.de> [150810 08:19]:
> +
> +/*
> +We need a better solution for this
> +*/
> +#include <../arch/arm/mach-omap2/omap-pm.h>

Please let's not do things like this, I end up having to deal with
all these eventually :(

> +static void iss_set_constraints(struct iss_device *iss, bool enable)
> +{
> +    if (!iss)
> +        return;
> +
> +    /* FIXME: Look for something more precise as a good throughtput limit */
> +    omap_pm_set_min_bus_tput(iss->dev, OCP_INITIATOR_AGENT,
> +                 enable ? 800000 : -1);
> +}
> +
> +static struct iss_platform_data iss_dummy_pdata = {
> +    .set_constraints = iss_set_constraints,
> +};

If this is one time setting, you could do it based on the
compatible string using arch/arm/mach-omap2/pdata-quirks.c.

If you need to toggle it, you could populate a function pointer
in pdata-quirks.c. Those are easy to fix once there is some Linux
generic API available :)

Regards,

Tony

  reply	other threads:[~2015-08-11 11:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 15:16 [PATCH RFC] DT support for omap4-iss Michael Allwright
2015-08-11 11:16 ` Tony Lindgren [this message]
2015-08-11 17:13   ` Michael Allwright
2015-08-19  8:37     ` Michael Allwright
2015-08-19 22:25     ` Laurent Pinchart
2015-08-26 20:28     ` Tony Lindgren
2015-08-19 22:23   ` Laurent Pinchart
2015-08-19 22:40 ` Laurent Pinchart
2015-08-19 22:45   ` Laurent Pinchart
2019-06-28 11:04 ` Sakari Ailus
2019-10-07 16:34   ` Tony Lindgren
2019-10-07 16:56     ` Michael Allwright
2019-10-07 18:16       ` H. Nikolaus Schaller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150811111604.GD10928@atomide.com \
    --to=tony@atomide.com \
    --cc=arnd@arndb.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=michael.allwright@upb.de \
    --cc=sakari.ailus@iki.fi \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.