From: "Pali Rohár" <pali.rohar@gmail.com>
To: Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bq2415x_charger: Allow to load and use driver even if notify device is not registered yet
Date: Tue, 11 Aug 2015 13:23:43 +0200 [thread overview]
Message-ID: <20150811112343.GA1461@pali> (raw)
In-Reply-To: <20150805132652.GB26280@pali>
On Wednesday 05 August 2015 15:26:52 Pali Rohár wrote:
> On Saturday 25 July 2015 23:46:56 Pali Rohár wrote:
> > - if (psy != bq->notify_psy)
> > - return NOTIFY_OK;
> > + /* Ignore event if it was not send by notify_node/notify_device */
> > + if (bq->notify_node) {
> > + if (psy->dev.parent &&
> > + psy->dev.parent->of_node != bq->notify_node)
> > + return NOTIFY_OK;
>
> There is missing branch for case when psy->dev.parent is NULL. Logical
> error... I will send new version of patch.
>
> Correct logic should be: ignore psy dev which sent event if it is not
> notify dev specified in board/DT config of bq2415x psy dev.
>
Fixed in v2.
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2015-08-11 11:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 21:46 [PATCH] bq2415x_charger: Allow to load and use driver even if notify device is not registered yet Pali Rohár
2015-08-05 13:26 ` Pali Rohár
2015-08-11 11:23 ` Pali Rohár [this message]
2015-08-11 11:22 ` [PATCH v2] " Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150811112343.GA1461@pali \
--to=pali.rohar@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.