From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965152AbbHKNg4 (ORCPT ); Tue, 11 Aug 2015 09:36:56 -0400 Received: from mga14.intel.com ([192.55.52.115]:7470 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964957AbbHKNgz (ORCPT ); Tue, 11 Aug 2015 09:36:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,653,1432623600"; d="scan'208";a="746392365" Date: Tue, 11 Aug 2015 06:36:55 -0700 From: Andi Kleen To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , linux-kernel@vger.kernel.org, Jiri Olsa , Arnaldo Carvalho de Melo Subject: Re: [PATCH 7/9] perf report: Add support for srcfile sort key Message-ID: <20150811133655.GC4524@tassilo.jf.intel.com> References: <1439240193-31520-1-git-send-email-acme@kernel.org> <1439240193-31520-8-git-send-email-acme@kernel.org> <20150811023136.GE2488@sejong> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150811023136.GE2488@sejong> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > AFAIK get_srcline() can return a string literal SRCLINE_UNKNOWN. It > should not be freed or altered.. Good point. Here's a patch. --- perf, tools: Check for SRCLINE_UNKNOWN case in srcline Handle the SRCLINE_UNKNOWN case correctly when processing srcfile. Pointed out by Namhyung. Signed-off-by: Andi Kleen diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index c0c32b0..7e38716 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -330,6 +330,8 @@ static char *get_srcfile(struct hist_entry *e) sf = get_srcline(map->dso, map__rip_2objdump(map, e->ip), e->ms.sym, true); + if (!strcmp(sf, SRCLINE_UNKNOWN)) + return no_srcfile; p = strchr(sf, ':'); if (p && *sf) { *p = 0;