From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH for-next V7 6/6] IB/ucma: HW Device hot-removal support Date: Tue, 11 Aug 2015 10:35:04 -0600 Message-ID: <20150811163504.GA3062@obsidianresearch.com> References: <1438697008-26209-1-git-send-email-yishaih@mellanox.com> <1438697008-26209-7-git-send-email-yishaih@mellanox.com> <20150804220903.GE10934@obsidianresearch.com> <55C22739.5060808@dev.mellanox.co.il> <20150805182117.GA15583@obsidianresearch.com> <20150811054852.GC13314@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Liran Liss Cc: "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , Yishai Hadas , Sean Hefty , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Shachar Raindel , Jack Morgenstein , Yishai Hadas List-Id: linux-rdma@vger.kernel.org On Tue, Aug 11, 2015 at 12:47:03PM +0000, Liran Liss wrote: > > Still needs to have the locking fixed.. > > As pointed out > (https://www.mail-archive.com/linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg27023.html), > this "barrier" scheme is used in several places including in the > RDMA stack. If there is no functional issue with the code, we can > discuss how to address this scheme systematically later. That's not an argument. closing has nonsensical locking, the ugly empty mutex is part of that same mess. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html