diff for duplicates of <20150811204127.31346.16729@quantum> diff --git a/a/1.txt b/N1/1.txt index 2b5f7fd..c23bd12 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,28 +6,26 @@ Quoting Joachim Eastwood (2015-07-11 14:48:26) > + const char *clk_32khz_parent; > + struct regmap *syscon; > + -> + syscon =3D syscon_node_to_regmap(np->parent); +> + syscon = syscon_node_to_regmap(np->parent); > + if (IS_ERR(syscon)) { > + pr_err("%s: syscon lookup failed\n", __func__); > + return; > + } > + -> + clk_32khz_parent =3D of_clk_get_parent_name(np, 0); +> + clk_32khz_parent = of_clk_get_parent_name(np, 0); > + -> + clk_creg[CREG_CLK_32KHZ] =3D +> + clk_creg[CREG_CLK_32KHZ] = > + clk_register_creg_clk(&clk_creg_clocks[CREG_CLK_32KHZ], > + &clk_32khz_parent, syscon); > + -> + clk_creg[CREG_CLK_1KHZ] =3D +> + clk_creg[CREG_CLK_1KHZ] = > + clk_register_creg_clk(&clk_creg_clocks[CREG_CLK_1KHZ], -> + &clk_creg_clocks[CREG_CLK_32KHZ].na= -me, +> + &clk_creg_clocks[CREG_CLK_32KHZ].name, > + syscon); > + > + of_clk_add_provider(np, of_clk_src_onecell_get, &clk_base_data); > +} -> +CLK_OF_DECLARE(lpc18xx_creg_clk, "nxp,lpc1850-creg-clk", lpc18xx_creg_cl= -k_init); +> +CLK_OF_DECLARE(lpc18xx_creg_clk, "nxp,lpc1850-creg-clk", lpc18xx_creg_clk_init); I'll ask the same question that Stephen asked in your CCU/CGU driver series: is it necessary to use CLK_OF_DECLARE here or can you use the diff --git a/a/content_digest b/N1/content_digest index 8bd324c..bf38a48 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,14 +1,9 @@ "ref\01436651307-24098-1-git-send-email-manabian@gmail.com\0" "ref\01436651307-24098-2-git-send-email-manabian@gmail.com\0" - "From\0Michael Turquette <mturquette@baylibre.com>\0" - "Subject\0Re: [PATCH 1/2] clk: add lpc18xx creg clk driver\0" + "From\0mturquette@baylibre.com (Michael Turquette)\0" + "Subject\0[PATCH 1/2] clk: add lpc18xx creg clk driver\0" "Date\0Tue, 11 Aug 2015 13:41:27 -0700\0" - "To\0Joachim Eastwood <manabian@gmail.com>" - " sboyd@codeaurora.org\0" - "Cc\0devicetree@vger.kernel.org" - Joachim Eastwood <manabian@gmail.com> - linux-clk@vger.kernel.org - " linux-arm-kernel@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi Joachim,\n" @@ -19,28 +14,26 @@ "> + const char *clk_32khz_parent;\n" "> + struct regmap *syscon;\n" "> +\n" - "> + syscon =3D syscon_node_to_regmap(np->parent);\n" + "> + syscon = syscon_node_to_regmap(np->parent);\n" "> + if (IS_ERR(syscon)) {\n" "> + pr_err(\"%s: syscon lookup failed\\n\", __func__);\n" "> + return;\n" "> + }\n" "> +\n" - "> + clk_32khz_parent =3D of_clk_get_parent_name(np, 0);\n" + "> + clk_32khz_parent = of_clk_get_parent_name(np, 0);\n" "> +\n" - "> + clk_creg[CREG_CLK_32KHZ] =3D\n" + "> + clk_creg[CREG_CLK_32KHZ] =\n" "> + clk_register_creg_clk(&clk_creg_clocks[CREG_CLK_32KHZ],\n" "> + &clk_32khz_parent, syscon);\n" "> +\n" - "> + clk_creg[CREG_CLK_1KHZ] =3D\n" + "> + clk_creg[CREG_CLK_1KHZ] =\n" "> + clk_register_creg_clk(&clk_creg_clocks[CREG_CLK_1KHZ],\n" - "> + &clk_creg_clocks[CREG_CLK_32KHZ].na=\n" - "me,\n" + "> + &clk_creg_clocks[CREG_CLK_32KHZ].name,\n" "> + syscon);\n" "> +\n" "> + of_clk_add_provider(np, of_clk_src_onecell_get, &clk_base_data);\n" "> +}\n" - "> +CLK_OF_DECLARE(lpc18xx_creg_clk, \"nxp,lpc1850-creg-clk\", lpc18xx_creg_cl=\n" - "k_init);\n" + "> +CLK_OF_DECLARE(lpc18xx_creg_clk, \"nxp,lpc1850-creg-clk\", lpc18xx_creg_clk_init);\n" "\n" "I'll ask the same question that Stephen asked in your CCU/CGU driver\n" "series: is it necessary to use CLK_OF_DECLARE here or can you use the\n" @@ -49,4 +42,4 @@ "Thanks,\n" Mike -2784e10290d324f3ffa2e270a84f6272726c252f453ee668a7815dc586b5177f +1acad7294f75fc8a7ed3732a07a4dfa492243371939443050afcce1b2413d423
diff --git a/a/1.txt b/N2/1.txt index 2b5f7fd..2411d7e 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -6,28 +6,26 @@ Quoting Joachim Eastwood (2015-07-11 14:48:26) > + const char *clk_32khz_parent; > + struct regmap *syscon; > + -> + syscon =3D syscon_node_to_regmap(np->parent); +> + syscon = syscon_node_to_regmap(np->parent); > + if (IS_ERR(syscon)) { > + pr_err("%s: syscon lookup failed\n", __func__); > + return; > + } > + -> + clk_32khz_parent =3D of_clk_get_parent_name(np, 0); +> + clk_32khz_parent = of_clk_get_parent_name(np, 0); > + -> + clk_creg[CREG_CLK_32KHZ] =3D +> + clk_creg[CREG_CLK_32KHZ] = > + clk_register_creg_clk(&clk_creg_clocks[CREG_CLK_32KHZ], > + &clk_32khz_parent, syscon); > + -> + clk_creg[CREG_CLK_1KHZ] =3D +> + clk_creg[CREG_CLK_1KHZ] = > + clk_register_creg_clk(&clk_creg_clocks[CREG_CLK_1KHZ], -> + &clk_creg_clocks[CREG_CLK_32KHZ].na= -me, +> + &clk_creg_clocks[CREG_CLK_32KHZ].name, > + syscon); > + > + of_clk_add_provider(np, of_clk_src_onecell_get, &clk_base_data); > +} -> +CLK_OF_DECLARE(lpc18xx_creg_clk, "nxp,lpc1850-creg-clk", lpc18xx_creg_cl= -k_init); +> +CLK_OF_DECLARE(lpc18xx_creg_clk, "nxp,lpc1850-creg-clk", lpc18xx_creg_clk_init); I'll ask the same question that Stephen asked in your CCU/CGU driver series: is it necessary to use CLK_OF_DECLARE here or can you use the @@ -35,3 +33,7 @@ platform device model? Thanks, Mike +-- +To unsubscribe from this list: send the line "unsubscribe devicetree" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 8bd324c..48d9722 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,14 +1,14 @@ "ref\01436651307-24098-1-git-send-email-manabian@gmail.com\0" "ref\01436651307-24098-2-git-send-email-manabian@gmail.com\0" - "From\0Michael Turquette <mturquette@baylibre.com>\0" + "ref\01436651307-24098-2-git-send-email-manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org\0" + "From\0Michael Turquette <mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>\0" "Subject\0Re: [PATCH 1/2] clk: add lpc18xx creg clk driver\0" "Date\0Tue, 11 Aug 2015 13:41:27 -0700\0" - "To\0Joachim Eastwood <manabian@gmail.com>" - " sboyd@codeaurora.org\0" - "Cc\0devicetree@vger.kernel.org" - Joachim Eastwood <manabian@gmail.com> - linux-clk@vger.kernel.org - " linux-arm-kernel@lists.infradead.org\0" + "To\0sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org\0" + "Cc\0devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" + Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> + linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + " linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org\0" "\00:1\0" "b\0" "Hi Joachim,\n" @@ -19,34 +19,36 @@ "> + const char *clk_32khz_parent;\n" "> + struct regmap *syscon;\n" "> +\n" - "> + syscon =3D syscon_node_to_regmap(np->parent);\n" + "> + syscon = syscon_node_to_regmap(np->parent);\n" "> + if (IS_ERR(syscon)) {\n" "> + pr_err(\"%s: syscon lookup failed\\n\", __func__);\n" "> + return;\n" "> + }\n" "> +\n" - "> + clk_32khz_parent =3D of_clk_get_parent_name(np, 0);\n" + "> + clk_32khz_parent = of_clk_get_parent_name(np, 0);\n" "> +\n" - "> + clk_creg[CREG_CLK_32KHZ] =3D\n" + "> + clk_creg[CREG_CLK_32KHZ] =\n" "> + clk_register_creg_clk(&clk_creg_clocks[CREG_CLK_32KHZ],\n" "> + &clk_32khz_parent, syscon);\n" "> +\n" - "> + clk_creg[CREG_CLK_1KHZ] =3D\n" + "> + clk_creg[CREG_CLK_1KHZ] =\n" "> + clk_register_creg_clk(&clk_creg_clocks[CREG_CLK_1KHZ],\n" - "> + &clk_creg_clocks[CREG_CLK_32KHZ].na=\n" - "me,\n" + "> + &clk_creg_clocks[CREG_CLK_32KHZ].name,\n" "> + syscon);\n" "> +\n" "> + of_clk_add_provider(np, of_clk_src_onecell_get, &clk_base_data);\n" "> +}\n" - "> +CLK_OF_DECLARE(lpc18xx_creg_clk, \"nxp,lpc1850-creg-clk\", lpc18xx_creg_cl=\n" - "k_init);\n" + "> +CLK_OF_DECLARE(lpc18xx_creg_clk, \"nxp,lpc1850-creg-clk\", lpc18xx_creg_clk_init);\n" "\n" "I'll ask the same question that Stephen asked in your CCU/CGU driver\n" "series: is it necessary to use CLK_OF_DECLARE here or can you use the\n" "platform device model?\n" "\n" "Thanks,\n" - Mike + "Mike\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -2784e10290d324f3ffa2e270a84f6272726c252f453ee668a7815dc586b5177f +40909001909b8e1e0d93c08d48505799959e2e758da2b6da52877f7baf155d32
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.