From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Swee Hua Law <sweehua81@gmail.com>
Cc: andreas.dilger@intel.com, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, hamohammed.sa@gmail.com,
linux-kernel@vger.kernel.org, HPDD-discuss@ml01.01.org,
Julia.Lawall@lip6.fr, viro@zeniv.linux.org.uk
Subject: Re: [PATCH 2/3] staging: lustre: Add blank line after variable declaration
Date: Wed, 12 Aug 2015 10:30:27 +0530 [thread overview]
Message-ID: <20150812050027.GA23011@sudip-pc> (raw)
In-Reply-To: <1439299951-2012-3-git-send-email-sweehua81@gmail.com>
On Tue, Aug 11, 2015 at 09:32:30PM +0800, Swee Hua Law wrote:
> Add blank line after variable declaration
>
> Signed-off-by: Swee Hua Law <sweehua81@gmail.com>
> ---
> drivers/staging/lustre/lustre/llite/lloop.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/lustre/lustre/llite/lloop.c b/drivers/staging/lustre/lustre/llite/lloop.c
> index b643f11..de5eaa0 100644
> --- a/drivers/staging/lustre/lustre/llite/lloop.c
> +++ b/drivers/staging/lustre/lustre/llite/lloop.c
> @@ -372,9 +372,11 @@ err:
> static inline void loop_handle_bio(struct lloop_device *lo, struct bio *bio)
> {
> int ret;
> +
> ret = do_bio_lustrebacked(lo, bio);
> while (bio) {
> struct bio *tmp = bio->bi_next;
> +
> bio->bi_next = NULL;
> bio_endio(bio);
This patch will not apply. I am not sure how your tree got
bio_endio(bio) but in the staging tree this line is bio_endio(bio, ret);
regards
sudip
next prev parent reply other threads:[~2015-08-12 5:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 13:32 [PATCH 0/3] staging: lustre: fix checkpatch problems in llite/lloop.c Swee Hua Law
2015-08-11 13:32 ` [PATCH 1/3] staging: lustre: Do not init global to NULL Swee Hua Law
2015-08-11 13:32 ` [PATCH 2/3] staging: lustre: Add blank line after variable declaration Swee Hua Law
2015-08-12 5:00 ` Sudip Mukherjee [this message]
2015-08-12 6:31 ` Joe Perches
2015-08-11 13:32 ` [PATCH 3/3] staging: lustre: Remove the space before \n Swee Hua Law
2015-08-11 14:00 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150812050027.GA23011@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=Julia.Lawall@lip6.fr \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sweehua81@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.