From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Adrien Schildknecht <adrien+dev@schischi.me>
Cc: helmut.schaa@googlemail.com, kvalo@codeaurora.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rt2x00: adjust EEPROM_SIZE for rt2500usb
Date: Wed, 12 Aug 2015 11:00:24 +0200 [thread overview]
Message-ID: <20150812090023.GA1862@redhat.com> (raw)
In-Reply-To: <1439245553-2840-1-git-send-email-adrien+dev@schischi.me>
On Tue, Aug 11, 2015 at 12:25:53AM +0200, Adrien Schildknecht wrote:
> rt2500usb_validate_eeprom() read data up to 0x6e (EEPROM_CALIBRATE_OFFSET)
> but only 0x6a bytes has been allocated and read from the eeprom.
>
> This lead to out-of-bound accesses and invalid values for
> EEPROM_BBPTUNE_R17 and EEPROM_CALIBRATE_OFFSET.
>
> Change the EEPROM_SIZE to 0x6e in order to retrieve all the fields.
>
> Tested with a rt2570 device.
>
> Signed-off-by: Adrien Schildknecht <adrien+dev@schischi.me>
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
next prev parent reply other threads:[~2015-08-12 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 22:25 [PATCH] rt2x00: adjust EEPROM_SIZE for rt2500usb Adrien Schildknecht
2015-08-12 9:00 ` Stanislaw Gruszka [this message]
2015-08-18 6:05 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150812090023.GA1862@redhat.com \
--to=sgruszka@redhat.com \
--cc=adrien+dev@schischi.me \
--cc=helmut.schaa@googlemail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.