From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752179AbbHLLya (ORCPT ); Wed, 12 Aug 2015 07:54:30 -0400 Received: from mga03.intel.com ([134.134.136.65]:35029 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbbHLLy3 (ORCPT ); Wed, 12 Aug 2015 07:54:29 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,660,1432623600"; d="scan'208";a="747091757" Date: Wed, 12 Aug 2015 14:52:18 +0300 From: Mika Westerberg To: Andy Shevchenko Cc: "Rafael J . Wysocki" , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/3] device property: attach 'else if' to the proper 'if' Message-ID: <20150812115218.GR1541@lahna.fi.intel.com> References: <1439225808-132916-1-git-send-email-andriy.shevchenko@linux.intel.com> <1439225808-132916-3-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439225808-132916-3-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 10, 2015 at 07:56:48PM +0300, Andy Shevchenko wrote: > Obviously in the current place the 'else' keyword is redundant, though it seems > quite correct when we check if nval is in allowed range. > > Reattach the condition branch there. > > Signed-off-by: Andy Shevchenko When the leftovers you mentioned are dropped you can add my, Reviewed-by: Mika Westerberg