All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: linux-arch@vger.kernel.org,
	"ksummit-discuss@lists.linuxfoundation.org"
	<ksummit-discuss@lists.linuxfoundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Chris Metcalf <cmetcalf@ezchip.com>,
	Christoph Lameter <cl@linux.com>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [Ksummit-discuss] [BELATED CORE TOPIC] context tracking / nohz / RCU state
Date: Wed, 12 Aug 2015 08:59:19 -0700	[thread overview]
Message-ID: <20150812155919.GU3895@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150812143819.GE21542@lerouge>

On Wed, Aug 12, 2015 at 04:38:21PM +0200, Frederic Weisbecker wrote:
> On Tue, Aug 11, 2015 at 11:33:12AM -0700, Paul E. McKenney wrote:
> > On Tue, Aug 11, 2015 at 10:49:36AM -0700, Andy Lutomirski wrote:
> > > Some arches may need:
> > > 
> > > i_am_lame_and_forgot_my_previous_context()
> > > 
> > > x86 will soon (4.3 or 4.4, depending on how my syscall cleanup goes)
> > > no longer need that.
> > > 
> > > Paul says that some arches need something that goes straight from IRQ
> > > to user mode (?) -- sigh.
> > 
> > Straight from IRQ to process-level kernel mode.  I ran into this in
> > late 2011, and clearly should have documented exactly what code was
> > doing this.  Something about invoking system calls from within the
> > kernel on some architectures.
> > 
> > Hey, if no architectures do this anymore, I could simplify RCU a bit!  ;-)
> 
> That issue has always been a bit foggy to me :-)
> 
> We never really stated what exactly the issue was. Just performing syscalls
> from kernel mode shouldn't fiddle with the dynticks count.
> 
> IIUC, the issue was that some IRQs triggered and never returned. But we
> certainly can't remove the safety code without clearly identifying the
> issue...

This was not a theoretical problem -- there were real failures.

But yes, the safety code is there and seems to work OK, so I do need
confirmation of a change before removing it.  I do recall someone
arguing that the half-interrupts should go away, but I never did hear
that they really did go away.

Adding linux-arch in the hope that someone can say for sure.

							Thanx, Paul

WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
	"ksummit-discuss@lists.linuxfoundation.org"
	<ksummit-discuss@lists.linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Christoph Lameter <cl@linux.com>, Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Chris Metcalf <cmetcalf@ezchip.com>,
	Rik van Riel <riel@redhat.com>,
	benh@kernel.crashing.org, will.deacon@arm.com,
	linux-arch@vger.kernel.org
Subject: Re: [BELATED CORE TOPIC] context tracking / nohz / RCU state
Date: Wed, 12 Aug 2015 08:59:19 -0700	[thread overview]
Message-ID: <20150812155919.GU3895@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150812143819.GE21542@lerouge>

On Wed, Aug 12, 2015 at 04:38:21PM +0200, Frederic Weisbecker wrote:
> On Tue, Aug 11, 2015 at 11:33:12AM -0700, Paul E. McKenney wrote:
> > On Tue, Aug 11, 2015 at 10:49:36AM -0700, Andy Lutomirski wrote:
> > > Some arches may need:
> > > 
> > > i_am_lame_and_forgot_my_previous_context()
> > > 
> > > x86 will soon (4.3 or 4.4, depending on how my syscall cleanup goes)
> > > no longer need that.
> > > 
> > > Paul says that some arches need something that goes straight from IRQ
> > > to user mode (?) -- sigh.
> > 
> > Straight from IRQ to process-level kernel mode.  I ran into this in
> > late 2011, and clearly should have documented exactly what code was
> > doing this.  Something about invoking system calls from within the
> > kernel on some architectures.
> > 
> > Hey, if no architectures do this anymore, I could simplify RCU a bit!  ;-)
> 
> That issue has always been a bit foggy to me :-)
> 
> We never really stated what exactly the issue was. Just performing syscalls
> from kernel mode shouldn't fiddle with the dynticks count.
> 
> IIUC, the issue was that some IRQs triggered and never returned. But we
> certainly can't remove the safety code without clearly identifying the
> issue...

This was not a theoretical problem -- there were real failures.

But yes, the safety code is there and seems to work OK, so I do need
confirmation of a change before removing it.  I do recall someone
arguing that the half-interrupts should go away, but I never did hear
that they really did go away.

Adding linux-arch in the hope that someone can say for sure.

							Thanx, Paul

  reply	other threads:[~2015-08-12 15:59 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 17:49 [Ksummit-discuss] [BELATED CORE TOPIC] context tracking / nohz / RCU state Andy Lutomirski
2015-08-11 17:49 ` Andy Lutomirski
2015-08-11 18:33 ` [Ksummit-discuss] " Paul E. McKenney
2015-08-11 18:33   ` Paul E. McKenney
2015-08-11 19:07   ` [Ksummit-discuss] " Andy Lutomirski
2015-08-11 19:07     ` Andy Lutomirski
2015-08-11 21:47     ` [Ksummit-discuss] " Paul E. McKenney
2015-08-11 21:47       ` Paul E. McKenney
2015-08-11 21:52       ` [Ksummit-discuss] " Andy Lutomirski
2015-08-11 21:52         ` Andy Lutomirski
2015-08-12  0:51         ` [Ksummit-discuss] " Paul E. McKenney
2015-08-12  0:51           ` Paul E. McKenney
2015-08-12  1:16           ` [Ksummit-discuss] " Andy Lutomirski
2015-08-12  1:16             ` Andy Lutomirski
2015-08-12 13:38             ` [Ksummit-discuss] " Paul E. McKenney
2015-08-12 13:38               ` Paul E. McKenney
2015-08-12 14:52     ` [Ksummit-discuss] " Frederic Weisbecker
2015-08-12 14:52       ` Frederic Weisbecker
2015-08-12 14:38   ` [Ksummit-discuss] " Frederic Weisbecker
2015-08-12 14:38     ` Frederic Weisbecker
2015-08-12 15:59     ` Paul E. McKenney [this message]
2015-08-12 15:59       ` Paul E. McKenney
2015-08-11 18:42 ` [Ksummit-discuss] " Luis R. Rodriguez
2015-08-11 18:42   ` Luis R. Rodriguez
2015-08-11 21:50   ` Paul E. McKenney
2015-08-11 21:50     ` Paul E. McKenney
2015-08-12 20:17     ` Luis R. Rodriguez
2015-08-12 20:17       ` Luis R. Rodriguez
2015-08-12 14:27   ` Frederic Weisbecker
2015-08-12 14:27     ` Frederic Weisbecker
2015-08-12 16:03     ` Paul E. McKenney
2015-08-12 16:03       ` Paul E. McKenney
2015-08-13  1:29       ` Lai Jiangshan
2015-08-13  1:29         ` Lai Jiangshan
2015-08-13 13:07         ` Frederic Weisbecker
2015-08-13 13:07           ` Frederic Weisbecker
2015-08-13 13:03       ` Frederic Weisbecker
2015-08-13 13:03         ` Frederic Weisbecker
2015-08-11 19:31 ` josh
2015-08-11 19:31   ` josh
2015-08-11 21:32 ` Kevin Hilman
2015-08-11 21:32   ` Kevin Hilman
2015-08-12  3:56 ` [Ksummit-discuss] " Lai Jiangshan
2015-08-12  3:56   ` Lai Jiangshan
2015-08-12 14:20 ` Frederic Weisbecker
2015-08-12 14:20   ` Frederic Weisbecker
2015-10-12 18:40 ` [Ksummit-discuss] " Theodore Ts'o
2015-10-12 18:40   ` Theodore Ts'o
2015-10-12 19:55   ` Thomas Gleixner
2015-10-12 19:55     ` Thomas Gleixner
2015-10-12 20:40   ` Paul E. McKenney
2015-10-16 17:02     ` Frederic Weisbecker
2015-10-16 17:02       ` Frederic Weisbecker
2015-10-17 19:45       ` Theodore Ts'o
2015-10-17 19:45         ` Theodore Ts'o
2015-10-19 14:14         ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150812155919.GU3895@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=cl@linux.com \
    --cc=cmetcalf@ezchip.com \
    --cc=fweisbec@gmail.com \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.