All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: f2fs: callers take care of the page from bio error
Date: Wed, 12 Aug 2015 21:23:40 +0300	[thread overview]
Message-ID: <20150812182340.GI32040@mwanda> (raw)
In-Reply-To: <20150812171837.GB27478@jaegeuk-mac02.mot.com>

On Wed, Aug 12, 2015 at 10:18:37AM -0700, Jaegeuk Kim wrote:
> >   1041          err = read_node_page(apage, READA);
> >   1042          f2fs_put_page(apage, err ? 1 : 0);
> > 
> > In the old code we took errors into consideration but now we treat them
> > as LOCKED_PAGE.  Is that intentional?  A lot of the other callers in
> > that patch still check for errors...
> 
> This is just for read-ahead node page function.
> So, yes, if it returns LOCKED_PAGE or any error, the page must be unlocked
> via f2fs_put_page(1).
> Otherwise, end_io will unlock the page.
> 
> Hmm, any workaround to avoid that warning?
> 

No, it's fine.  Just ignore it.

regards,
dan carpenter


------------------------------------------------------------------------------

      reply	other threads:[~2015-08-12 18:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12 10:40 f2fs: callers take care of the page from bio error Dan Carpenter
2015-08-12 17:18 ` Jaegeuk Kim
2015-08-12 18:23   ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150812182340.GI32040@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.