From: Peng Fan <b51431@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] imx-common: consolidate macros and prototypes into sys_proto.h
Date: Thu, 13 Aug 2015 08:26:04 +0800 [thread overview]
Message-ID: <20150813002604.GB25619@shlinux2> (raw)
In-Reply-To: <55CB6AFB.8060502@denx.de>
Hi Stefano,
On Wed, Aug 12, 2015 at 05:49:15PM +0200, Stefano Babic wrote:
>Hi Peng,
>
>On 10/08/2015 14:53, Peng Fan wrote:
>> Move most macro definitions and prototypes into
>> "arch/arm/include/asm/imx-common/sys_proto.h" to avoid duplicated
>> function prototypes and marco definitions for different i.MX SoCs.
>>
>> This patch do not remove the sys_proto.h for different i.MX SoCs,
>> because we need to modify lots of driver code and others. This patch
>> remove duplicated macros and prototypes and incude "sys_proto.h"
>> of imx-common for each sys_proto.h of different i.MX platforms.
>> Then later we should avoid add stuff in sys_proto.h of each platform,
>> and modify driver to include common sys_proto.h.
>>
>> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
>> Cc: Stefano Babic <sbabic@denx.de>
>> ---
>> arch/arm/include/asm/arch-mx31/sys_proto.h | 7 ++---
>> arch/arm/include/asm/arch-mx35/sys_proto.h | 12 ++++----
>> arch/arm/include/asm/arch-mx5/sys_proto.h | 22 +-------------
>> arch/arm/include/asm/arch-mx6/sys_proto.h | 45 +----------------------------
>> arch/arm/include/asm/arch-mxs/sys_proto.h | 15 ++--------
>> arch/arm/include/asm/imx-common/sys_proto.h | 45 +++++++++++++++++++++++++++++
>> 6 files changed, 59 insertions(+), 87 deletions(-)
>> create mode 100644 arch/arm/include/asm/imx-common/sys_proto.h
>>
>
>This breaks MX35 boards:
>
>+In file included from include/asm/arch/sys_proto.h:11:0,
>+ from arch/arm/cpu/arm1136/mx35/mx35_sdram.c:11:
>+arch/arm/include/asm/imx-common/sys_proto.h:38:23: error: unknown type
>name 'bd_t'
>
>Reason is:
>
>int fecmxc_initialize(bd_t *bis);
>
>Can you check and resubmit ? Thanks !
Oh. I'll check this. I missed to build mx35 target.
[...]
Regards,
Peng.
--
next prev parent reply other threads:[~2015-08-13 0:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 12:53 [U-Boot] [PATCH 1/4] imx: add cpu type for i.MX2 and i.MX3 Peng Fan
2015-08-10 12:53 ` [U-Boot] [PATCH 2/4] imx: mx31 use new formula for get_cpu_rev Peng Fan
2015-08-11 10:45 ` Stefano Babic
2015-08-10 12:53 ` [U-Boot] [PATCH 3/4] imx: mxs: reimplement get_cpu_rev Peng Fan
2015-08-11 10:45 ` Stefano Babic
2015-08-10 12:53 ` [U-Boot] [PATCH 4/4] imx-common: consolidate macros and prototypes into sys_proto.h Peng Fan
2015-08-11 10:45 ` Stefano Babic
2015-08-12 15:49 ` Stefano Babic
2015-08-13 0:26 ` Peng Fan [this message]
2015-08-11 10:45 ` [U-Boot] [PATCH 1/4] imx: add cpu type for i.MX2 and i.MX3 Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813002604.GB25619@shlinux2 \
--to=b51431@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.