Re: [Qemu-devel] [PATCH v4 1/3] linux-headers: Add eeh.h

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1485 bytes --]

On Thu, Aug 13, 2015 at 11:30:37AM +1000, Gavin Shan wrote:
> On Wed, Aug 12, 2015 at 12:00:35PM +1000, Alexey Kardashevskiy wrote:
> >On 08/11/2015 07:11 PM, Peter Maydell wrote:
> >>On 10 August 2015 at 08:13, Gavin Shan <gwshan@linux.vnet.ibm.com> wrote:
> >>>The header file was introduced by following Linux upstream commits:
> >>>
> >>>     commit ed3e81f ("powerpc/eeh: Move PE state constants around")
> >>>     commit ec33d36 ("powerpc/eeh: Introduce eeh_pe_inject_err()")
> >>>
> >>>Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
> >>>---
> >>>  linux-headers/asm-powerpc/eeh.h | 56 +++++++++++++++++++++++++++++++++++++++++
> >>>  1 file changed, 56 insertions(+)
> >>>  create mode 100644 linux-headers/asm-powerpc/eeh.h
> >>
> >>Shouldn't this be added by updating scripts/update-linux-headers.sh
> >>and then doing a plain "synchronize headers against kernel version $X" ?
> >
> >
> >I also thought this is the protocol but then I looked into the git history
> >and discovered this is not always the case :)
> >
> >
> 
> So should I use scripts/update-linux-headers.sh or what I had is
> fine?

Please use update-linux-headers.sh - and make sure you also update the
script itself (if necessary) so it will pull in future updates to
eeh.h

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]