From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 04/13] drm/imx: Make pipe number unsigned Date: Thu, 13 Aug 2015 11:05:23 +0200 Message-ID: <20150813090522.GA21716@ulmo> References: <1439391635-29166-1-git-send-email-thierry.reding@gmail.com> <1439391635-29166-4-git-send-email-thierry.reding@gmail.com> <20150812152434.GI17734@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0397491967==" Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTPS id 519CA6E0E7 for ; Thu, 13 Aug 2015 02:06:22 -0700 (PDT) Received: by wicne3 with SMTP id ne3so250477322wic.1 for ; Thu, 13 Aug 2015 02:06:20 -0700 (PDT) In-Reply-To: <20150812152434.GI17734@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0397491967== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bp/iNruPH9dso1Pn" Content-Disposition: inline --bp/iNruPH9dso1Pn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 12, 2015 at 05:24:34PM +0200, Daniel Vetter wrote: > On Wed, Aug 12, 2015 at 05:00:26PM +0200, Thierry Reding wrote: > > From: Thierry Reding > >=20 > > There's no reason whatsoever why this should ever be negative. > >=20 > > Cc: Philipp Zabel > > Acked-by: Philipp Zabel > > Signed-off-by: Thierry Reding >=20 > Just kill it and replace with drm_crtc_index. Using that for vblank events > instead of some driver-specific thing is kinda abi. Would you mind if I did that as a follow-up? That way the changes per patch stay more concise. Thierry > > --- > > drivers/gpu/drm/imx/imx-drm-core.c | 4 ++-- > > drivers/gpu/drm/imx/imx-drm.h | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > >=20 > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/i= mx-drm-core.c > > index 74f505b0dd02..c50cd97b1c4e 100644 > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > @@ -45,14 +45,14 @@ struct imx_drm_device { > > =20 > > struct imx_drm_crtc { > > struct drm_crtc *crtc; > > - int pipe; > > + unsigned int pipe; > > struct imx_drm_crtc_helper_funcs imx_drm_helper_funcs; > > }; > > =20 > > static int legacyfb_depth =3D 16; > > module_param(legacyfb_depth, int, 0444); > > =20 > > -int imx_drm_crtc_id(struct imx_drm_crtc *crtc) > > +unsigned int imx_drm_crtc_id(struct imx_drm_crtc *crtc) > > { > > return crtc->pipe; > > } > > diff --git a/drivers/gpu/drm/imx/imx-drm.h b/drivers/gpu/drm/imx/imx-dr= m.h > > index 28e776d8d9d2..eebf0e2fefd0 100644 > > --- a/drivers/gpu/drm/imx/imx-drm.h > > +++ b/drivers/gpu/drm/imx/imx-drm.h > > @@ -12,7 +12,7 @@ struct drm_framebuffer; > > struct imx_drm_crtc; > > struct platform_device; > > =20 > > -int imx_drm_crtc_id(struct imx_drm_crtc *crtc); > > +unsigned int imx_drm_crtc_id(struct imx_drm_crtc *crtc); > > =20 > > struct imx_drm_crtc_helper_funcs { > > int (*enable_vblank)(struct drm_crtc *crtc); > > --=20 > > 2.4.5 > >=20 >=20 > --=20 > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch --bp/iNruPH9dso1Pn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVzF3OAAoJEN0jrNd/PrOhnP4P/3ZLhOtw+x4r2/PdrEdmV3Zv iIBfA11tuZ1jgqNUOEPHrIXtFeosphc17vcg5u6bT/rZv2infABtHjTuxygL+xJg 5GPaj4xgQPQwOSxQUgpuAsff0OfQrdUxto/B1AxZWiEmNsZ+EXLpkadUYWaCiN6Q 6HdunWGYyNCHq7ges9dninAGS+4/4x8OgcFIhttMw1+LBD/tPhSfFKjOm5XveATe 2RAS0QwdBe+9RRm++c6+2qIQ9pKPTD2O2dVKjquccyNXiG92c2sHZiG2Tlh/UNxo Nhh41KY5EgDFEzlRTKj5v/sDyICtjLSunBs9oka/K35J5J6+6CE50I3N2+j26dYa oFoe5riBkhFRrsi2osI3mPWWY/w1xa2zwA0fOs3Jba2YgRp4fTQlTNsV4nlfoCaa 6aJ1Rur23ELtfG5JumOB5nB9Y2vFTOUHaaAWoGKpEWDGdcoXMWvBT38zgRPPvQqJ JNnFdq/hnvR7J4UXCjq7qtE8wSf4+BRgRrzZ8HgJ1RnIbMj86MMB5DKFsIsb//Do l0lMVDPgb1KsWhls3NyAs5SPcRFr0pOOh2TIWlY/JA6Nez979W8u8/V6LRgw389T wLKpFYbOUs9u42w252MNUAoN6ma11Tc5WTqUwwm0mdQ5TOsozyOalIAm68xK7WMD Y30hlNtcnFjzqRBuNr1b =W5tC -----END PGP SIGNATURE----- --bp/iNruPH9dso1Pn-- --===============0397491967== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0397491967==--