From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 07/13] drm/sti: Store correct CRTC index in events Date: Thu, 13 Aug 2015 11:06:03 +0200 Message-ID: <20150813090602.GB21716@ulmo> References: <1439391635-29166-1-git-send-email-thierry.reding@gmail.com> <1439391635-29166-7-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0626701537==" Return-path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by gabe.freedesktop.org (Postfix) with ESMTPS id 677156E335 for ; Thu, 13 Aug 2015 02:06:59 -0700 (PDT) Received: by wicja10 with SMTP id ja10so143147791wic.1 for ; Thu, 13 Aug 2015 02:06:57 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Benjamin Gaignard Cc: Daniel Vetter , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org --===============0626701537== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wq9mPyueHGvFACwf" Content-Disposition: inline --wq9mPyueHGvFACwf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 12, 2015 at 05:26:01PM +0200, Benjamin Gaignard wrote: > The fix look good however it enter in conflict with the large rework > we have done to support atomic. > The pull request for this has been send. > Would it be ok for you if we include your patch in the your next > series of patches ? Sure, I can keep carrying this and rebase on your changes when they've landed. Thierry > 2015-08-12 17:00 GMT+02:00 Thierry Reding : > > From: Thierry Reding > > > > A negative pipe causes a special case to be triggered for drivers that > > don't have proper VBLANK support. STi does support VBLANKs, so there is > > no need for the fallback code. > > > > Cc: Benjamin Gaignard > > Signed-off-by: Thierry Reding > > --- > > drivers/gpu/drm/sti/sti_drm_crtc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/sti/sti_drm_crtc.c b/drivers/gpu/drm/sti/s= ti_drm_crtc.c > > index 26e63bf14efe..67279cc74348 100644 > > --- a/drivers/gpu/drm/sti/sti_drm_crtc.c > > +++ b/drivers/gpu/drm/sti/sti_drm_crtc.c > > @@ -234,7 +234,7 @@ int sti_drm_crtc_vblank_cb(struct notifier_block *n= b, > > > > spin_lock_irqsave(&drm_dev->event_lock, flags); > > if (compo->mixer[*crtc]->pending_event) { > > - drm_send_vblank_event(drm_dev, -1, > > + drm_send_vblank_event(drm_dev, *crtc, > > compo->mixer[*crtc]->pending_event); > > drm_vblank_put(drm_dev, *crtc); > > compo->mixer[*crtc]->pending_event =3D NULL; > > -- > > 2.4.5 > > >=20 >=20 >=20 > --=20 > Benjamin Gaignard >=20 > Graphic Working Group >=20 > Linaro.org =E2=94=82 Open source software for ARM SoCs >=20 > Follow Linaro: Facebook | Twitter | Blog --wq9mPyueHGvFACwf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIaBAABCAAGBQJVzF36AAoJEN0jrNd/PrOhUeYP72bSAqaNDS6GZfGtPKhUDAlC EmmEIJrhHM9Gfck5idPubLuKF5Cmpyeyf4x57oMox71rNg1bofjVHm3WIV+APBbG ujxltA4bTB0fPKE5nICWPmnvckJDAZZ/Wvv3Gswghs7xc/VPJ7p7nkq7zVWCdpTL nj0VokMxrg11Ni8MaGRO3ww4fTX5mx9EiZDivrtEvFY7yaoWcOUWgOLGNI04NzRK 5E4IeQQUDhLbz7RM6HI3CScnFpaKgu33UopR+HJLtxRZfmNZu925SZ41MA4E/ykR ukM5hrglziD/ffYVA3/YOFBMIFcD3Gup0n0dj2vz0aYAB1XlPJUV9THutghV5fcV FBd5iYCVwIj7OmEIagjjRbxd4l3jfbJ0rD4yOfX1gI8WgJH6dmSRlAEKRYrsaSn8 1UG8ht3Spd4V9DiRgeKSgxZqCwBEXD4GWIYnmXL7YkoJ6WRo64c0JZ7hYFJA/vrq IF1W+58crjFsAH2w/af681+ZZoF1NxkzhdOvNOpbzv8HReKpe62UUHTXDmHZay5P z9VPNcoF+3byiR7IzPwVNRBEOqsKYRnylgd2ZF/20pnF1O6B4dINleKlYVaUYrW1 TueZX3WMgw8boIQMk3gtRDaWaw4qHBqp2ZWB31VzuGpnwj/xeVsv4IbmfNkEjpgq ES/+4mLnp8DBu9fvXw== =1qyK -----END PGP SIGNATURE----- --wq9mPyueHGvFACwf-- --===============0626701537== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0626701537==--